Commit 62977281 authored by Stefan Bühler's avatar Stefan Bühler Committed by Jens Axboe

io_uring: remove unnecessary barrier after unsetting IORING_SQ_NEED_WAKEUP

There is no operation to order with afterwards, and removing the flag is
not critical in any way.

There will always be a "race condition" where the application will
trigger IORING_ENTER_SQ_WAKEUP when it isn't actually needed.
Signed-off-by: default avatarStefan Bühler <source@stbuehler.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent b841f195
...@@ -1969,13 +1969,11 @@ static int io_sq_thread(void *data) ...@@ -1969,13 +1969,11 @@ static int io_sq_thread(void *data)
finish_wait(&ctx->sqo_wait, &wait); finish_wait(&ctx->sqo_wait, &wait);
ctx->sq_ring->flags &= ~IORING_SQ_NEED_WAKEUP; ctx->sq_ring->flags &= ~IORING_SQ_NEED_WAKEUP;
smp_wmb();
continue; continue;
} }
finish_wait(&ctx->sqo_wait, &wait); finish_wait(&ctx->sqo_wait, &wait);
ctx->sq_ring->flags &= ~IORING_SQ_NEED_WAKEUP; ctx->sq_ring->flags &= ~IORING_SQ_NEED_WAKEUP;
smp_wmb();
} }
i = 0; i = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment