Commit 629821d9 authored by David S. Miller's avatar David S. Miller

Revert "xen: netback: remove redundant xenvif_put"

This reverts commit d3720456.

This change is incorrect, as per Jan Beulich:

====================
But this is wrong from all we can tell, we discussed this before
(Wei pointed to the discussion in an earlier reply). The core of
it is that the put here parallels the one in netbk_tx_err(), and
the one in xenvif_carrier_off() matches the get from
xenvif_connect() (which normally would be done on the path
coming through xenvif_disconnect()).
====================

And a previous discussion of this issue is at:

http://marc.info/?l=xen-devel&m=136084174026977&w=2Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 900ff8c6
...@@ -893,6 +893,7 @@ static void netbk_fatal_tx_err(struct xenvif *vif) ...@@ -893,6 +893,7 @@ static void netbk_fatal_tx_err(struct xenvif *vif)
{ {
netdev_err(vif->dev, "fatal error; disabling device\n"); netdev_err(vif->dev, "fatal error; disabling device\n");
xenvif_carrier_off(vif); xenvif_carrier_off(vif);
xenvif_put(vif);
} }
static int netbk_count_requests(struct xenvif *vif, static int netbk_count_requests(struct xenvif *vif,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment