Commit 62f8857b authored by Tom Rix's avatar Tom Rix Committed by Jiri Kosina

HID: amd_sfh: change global variables to static

Smatch reports this representative issue
amd_sfh_hid_report_desc.h:182:10: warning: symbol 'gyro3_report_descriptor' was not declared. Should it be static?
Similar issues for comp3_report_descriptor and als_report_descriptor.

Global variables should not be defined in header files.
This only works because amd_sfh_hid_report_desc.h in only included by
amd_sfh_hid_desc.c so change the storage-class specifiers to static.
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Acked-by: default avatarBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 5e206459
...@@ -179,7 +179,7 @@ static const u8 accel3_report_descriptor[] = { ...@@ -179,7 +179,7 @@ static const u8 accel3_report_descriptor[] = {
0xC0 /* HID end collection */ 0xC0 /* HID end collection */
}; };
const u8 gyro3_report_descriptor[] = { static const u8 gyro3_report_descriptor[] = {
0x05, 0x20, /* Usage page */ 0x05, 0x20, /* Usage page */
0x09, 0x76, /* Motion type Gyro3D */ 0x09, 0x76, /* Motion type Gyro3D */
0xA1, 0x00, /* HID Collection (Physical) */ 0xA1, 0x00, /* HID Collection (Physical) */
...@@ -340,7 +340,7 @@ const u8 gyro3_report_descriptor[] = { ...@@ -340,7 +340,7 @@ const u8 gyro3_report_descriptor[] = {
0xC0, /* HID end collection */ 0xC0, /* HID end collection */
}; };
const u8 comp3_report_descriptor[] = { static const u8 comp3_report_descriptor[] = {
0x05, 0x20, /* Usage page */ 0x05, 0x20, /* Usage page */
0x09, 0x83, /* Motion type Orientation compass 3D */ 0x09, 0x83, /* Motion type Orientation compass 3D */
0xA1, 0x00, /* HID Collection (Physical) */ 0xA1, 0x00, /* HID Collection (Physical) */
...@@ -512,7 +512,7 @@ const u8 comp3_report_descriptor[] = { ...@@ -512,7 +512,7 @@ const u8 comp3_report_descriptor[] = {
0xC0 /* HID end collection */ 0xC0 /* HID end collection */
}; };
const u8 als_report_descriptor[] = { static const u8 als_report_descriptor[] = {
0x05, 0x20, /* HID usage page sensor */ 0x05, 0x20, /* HID usage page sensor */
0x09, 0x41, /* HID usage sensor type Ambientlight */ 0x09, 0x41, /* HID usage sensor type Ambientlight */
0xA1, 0x00, /* HID Collection (Physical) */ 0xA1, 0x00, /* HID Collection (Physical) */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment