Commit 63e13252 authored by Amir Goldstein's avatar Amir Goldstein Committed by Miklos Szeredi

ovl: fix memory leak on unlink of indexed file

The memory leak was detected by kmemleak when running xfstests
overlay/051,053

Fixes: caf70cb2 ("ovl: cleanup orphan index entries")
Cc: <stable@vger.kernel.org> # v4.13
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 6bf4ca7f
...@@ -683,7 +683,7 @@ static void ovl_cleanup_index(struct dentry *dentry) ...@@ -683,7 +683,7 @@ static void ovl_cleanup_index(struct dentry *dentry)
struct dentry *upperdentry = ovl_dentry_upper(dentry); struct dentry *upperdentry = ovl_dentry_upper(dentry);
struct dentry *index = NULL; struct dentry *index = NULL;
struct inode *inode; struct inode *inode;
struct qstr name; struct qstr name = { };
int err; int err;
err = ovl_get_index_name(lowerdentry, &name); err = ovl_get_index_name(lowerdentry, &name);
...@@ -726,6 +726,7 @@ static void ovl_cleanup_index(struct dentry *dentry) ...@@ -726,6 +726,7 @@ static void ovl_cleanup_index(struct dentry *dentry)
goto fail; goto fail;
out: out:
kfree(name.name);
dput(index); dput(index);
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment