Commit 64038f29 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Ingo Molnar

stop_machine: Fix possible cpu_stopper_thread() crash

stop_one_cpu_nowait(fn) will crash the kernel if the callback returns
nonzero, work->done == NULL in this case.

This needs more cleanups, cpu_stop_signal_done() is called right after
we check done != NULL and it does the same check.
Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Milos Vyletel <milos@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20151115193311.GA8242@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 01783e0d
...@@ -454,7 +454,7 @@ static void cpu_stopper_thread(unsigned int cpu) ...@@ -454,7 +454,7 @@ static void cpu_stopper_thread(unsigned int cpu)
preempt_disable(); preempt_disable();
ret = fn(arg); ret = fn(arg);
if (ret) if (ret && done)
done->ret = ret; done->ret = ret;
/* restore preemption and check it's still balanced */ /* restore preemption and check it's still balanced */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment