Commit 64938182 authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman

staging: unisys: remove wmb() in visordriver_remove_device

Don't need to have a wmb() in visordriver_remove_device. Also removed
an unnecessary check for drv being null.
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 527486ee
...@@ -613,20 +613,12 @@ visordriver_remove_device(struct device *xdev) ...@@ -613,20 +613,12 @@ visordriver_remove_device(struct device *xdev)
drv = to_visor_driver(xdev->driver); drv = to_visor_driver(xdev->driver);
down(&dev->visordriver_callback_lock); down(&dev->visordriver_callback_lock);
dev->being_removed = true; dev->being_removed = true;
/* if (drv->remove)
* ensure that the dev->being_removed flag is set before we start the drv->remove(dev);
* actual removal
*/
wmb();
if (drv) {
if (drv->remove)
drv->remove(dev);
}
up(&dev->visordriver_callback_lock); up(&dev->visordriver_callback_lock);
dev_stop_periodic_work(dev); dev_stop_periodic_work(dev);
put_device(&dev->device); put_device(&dev->device);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment