Commit 64e724f6 authored by Brian Haley's avatar Brian Haley Committed by David S. Miller

ipv6: Don't add routes to ipv6 disabled interfaces.

If the interface has IPv6 disabled, don't add a multicast or
link-local route since we won't be adding a link-local address.
Reported-by: default avatarMahesh Kelkar <maheshkelkar@gmail.com>
Signed-off-by: default avatarBrian Haley <brian.haley@hp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent be2b6e62
...@@ -1760,7 +1760,10 @@ static struct inet6_dev *addrconf_add_dev(struct net_device *dev) ...@@ -1760,7 +1760,10 @@ static struct inet6_dev *addrconf_add_dev(struct net_device *dev)
idev = ipv6_find_idev(dev); idev = ipv6_find_idev(dev);
if (!idev) if (!idev)
return NULL; return ERR_PTR(-ENOBUFS);
if (idev->cnf.disable_ipv6)
return ERR_PTR(-EACCES);
/* Add default multicast route */ /* Add default multicast route */
addrconf_add_mroute(dev); addrconf_add_mroute(dev);
...@@ -2129,8 +2132,9 @@ static int inet6_addr_add(struct net *net, int ifindex, struct in6_addr *pfx, ...@@ -2129,8 +2132,9 @@ static int inet6_addr_add(struct net *net, int ifindex, struct in6_addr *pfx,
if (!dev) if (!dev)
return -ENODEV; return -ENODEV;
if ((idev = addrconf_add_dev(dev)) == NULL) idev = addrconf_add_dev(dev);
return -ENOBUFS; if (IS_ERR(idev))
return PTR_ERR(idev);
scope = ipv6_addr_scope(pfx); scope = ipv6_addr_scope(pfx);
...@@ -2377,7 +2381,7 @@ static void addrconf_dev_config(struct net_device *dev) ...@@ -2377,7 +2381,7 @@ static void addrconf_dev_config(struct net_device *dev)
} }
idev = addrconf_add_dev(dev); idev = addrconf_add_dev(dev);
if (idev == NULL) if (IS_ERR(idev))
return; return;
memset(&addr, 0, sizeof(struct in6_addr)); memset(&addr, 0, sizeof(struct in6_addr));
...@@ -2468,7 +2472,7 @@ static void addrconf_ip6_tnl_config(struct net_device *dev) ...@@ -2468,7 +2472,7 @@ static void addrconf_ip6_tnl_config(struct net_device *dev)
ASSERT_RTNL(); ASSERT_RTNL();
idev = addrconf_add_dev(dev); idev = addrconf_add_dev(dev);
if (!idev) { if (IS_ERR(idev)) {
printk(KERN_DEBUG "init ip6-ip6: add_dev failed\n"); printk(KERN_DEBUG "init ip6-ip6: add_dev failed\n");
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment