Commit 656f978f authored by Quentin Lambert's avatar Quentin Lambert Committed by Bjorn Helgaas

PCI: Remove unnecessary curly braces

Remove curly braces in simple "if" cases.

No functional change.
Signed-off-by: default avatarQuentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 382a9c9a
...@@ -467,9 +467,9 @@ check_slots(void) ...@@ -467,9 +467,9 @@ check_slots(void)
__func__, slot_name(slot), hs_csr); __func__, slot_name(slot), hs_csr);
if (!slot->extracting) { if (!slot->extracting) {
if (update_latch_status(slot->hotplug_slot, 0)) { if (update_latch_status(slot->hotplug_slot, 0))
warn("failure to update latch file"); warn("failure to update latch file");
}
slot->extracting = 1; slot->extracting = 1;
atomic_inc(&extracting); atomic_inc(&extracting);
} }
......
...@@ -182,9 +182,9 @@ static int zt5550_hc_enable_irq(void) ...@@ -182,9 +182,9 @@ static int zt5550_hc_enable_irq(void)
{ {
u8 reg; u8 reg;
if (hc_dev == NULL) { if (hc_dev == NULL)
return -ENODEV; return -ENODEV;
}
reg = readb(csr_int_mask); reg = readb(csr_int_mask);
reg = reg & ~ENUM_INT_MASK; reg = reg & ~ENUM_INT_MASK;
writeb(reg, csr_int_mask); writeb(reg, csr_int_mask);
...@@ -195,9 +195,8 @@ static int zt5550_hc_disable_irq(void) ...@@ -195,9 +195,8 @@ static int zt5550_hc_disable_irq(void)
{ {
u8 reg; u8 reg;
if (hc_dev == NULL) { if (hc_dev == NULL)
return -ENODEV; return -ENODEV;
}
reg = readb(csr_int_mask); reg = readb(csr_int_mask);
reg = reg | ENUM_INT_MASK; reg = reg | ENUM_INT_MASK;
...@@ -210,9 +209,9 @@ static int zt5550_hc_init_one (struct pci_dev *pdev, const struct pci_device_id ...@@ -210,9 +209,9 @@ static int zt5550_hc_init_one (struct pci_dev *pdev, const struct pci_device_id
int status; int status;
status = zt5550_hc_config(pdev); status = zt5550_hc_config(pdev);
if (status != 0) { if (status != 0)
return status; return status;
}
dbg("returned from zt5550_hc_config"); dbg("returned from zt5550_hc_config");
memset(&zt5550_hpc, 0, sizeof (struct cpci_hp_controller)); memset(&zt5550_hpc, 0, sizeof (struct cpci_hp_controller));
......
...@@ -1096,9 +1096,8 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -1096,9 +1096,8 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
/* initialize our threads if they haven't already been started up */ /* initialize our threads if they haven't already been started up */
rc = one_time_init(); rc = one_time_init();
if (rc) { if (rc)
goto err_free_bus; goto err_free_bus;
}
dbg("pdev = %p\n", pdev); dbg("pdev = %p\n", pdev);
dbg("pci resource start %llx\n", (unsigned long long)pci_resource_start(pdev, 0)); dbg("pci resource start %llx\n", (unsigned long long)pci_resource_start(pdev, 0));
......
...@@ -705,9 +705,8 @@ static struct pci_resource *get_max_resource(struct pci_resource **head, u32 siz ...@@ -705,9 +705,8 @@ static struct pci_resource *get_max_resource(struct pci_resource **head, u32 siz
if (temp == max) { if (temp == max) {
*head = max->next; *head = max->next;
} else { } else {
while (temp && temp->next != max) { while (temp && temp->next != max)
temp = temp->next; temp = temp->next;
}
if (temp) if (temp)
temp->next = max->next; temp->next = max->next;
...@@ -903,9 +902,8 @@ irqreturn_t cpqhp_ctrl_intr(int IRQ, void *data) ...@@ -903,9 +902,8 @@ irqreturn_t cpqhp_ctrl_intr(int IRQ, void *data)
/* /*
* Check to see if it was our interrupt * Check to see if it was our interrupt
*/ */
if (!(misc & 0x000C)) { if (!(misc & 0x000C))
return IRQ_NONE; return IRQ_NONE;
}
if (misc & 0x0004) { if (misc & 0x0004) {
/* /*
...@@ -2006,9 +2004,8 @@ int cpqhp_process_SI(struct controller *ctrl, struct pci_func *func) ...@@ -2006,9 +2004,8 @@ int cpqhp_process_SI(struct controller *ctrl, struct pci_func *func)
/* Check to see if the interlock is closed */ /* Check to see if the interlock is closed */
tempdword = readl(ctrl->hpc_reg + INT_INPUT_CLEAR); tempdword = readl(ctrl->hpc_reg + INT_INPUT_CLEAR);
if (tempdword & (0x01 << hp_slot)) { if (tempdword & (0x01 << hp_slot))
return 1; return 1;
}
if (func->is_a_board) { if (func->is_a_board) {
rc = board_replaced(func, ctrl); rc = board_replaced(func, ctrl);
...@@ -2070,9 +2067,8 @@ int cpqhp_process_SI(struct controller *ctrl, struct pci_func *func) ...@@ -2070,9 +2067,8 @@ int cpqhp_process_SI(struct controller *ctrl, struct pci_func *func)
} }
} }
if (rc) { if (rc)
dbg("%s: rc = %d\n", __func__, rc); dbg("%s: rc = %d\n", __func__, rc);
}
if (p_slot) if (p_slot)
update_slot_info(ctrl, p_slot); update_slot_info(ctrl, p_slot);
...@@ -2095,9 +2091,8 @@ int cpqhp_process_SS(struct controller *ctrl, struct pci_func *func) ...@@ -2095,9 +2091,8 @@ int cpqhp_process_SS(struct controller *ctrl, struct pci_func *func)
device = func->device; device = func->device;
func = cpqhp_slot_find(ctrl->bus, device, index++); func = cpqhp_slot_find(ctrl->bus, device, index++);
p_slot = cpqhp_find_slot(ctrl, device); p_slot = cpqhp_find_slot(ctrl, device);
if (p_slot) { if (p_slot)
physical_slot = p_slot->number; physical_slot = p_slot->number;
}
/* Make sure there are no video controllers here */ /* Make sure there are no video controllers here */
while (func && !rc) { while (func && !rc) {
......
...@@ -204,9 +204,8 @@ static int load_HRT (void __iomem *rom_start) ...@@ -204,9 +204,8 @@ static int load_HRT (void __iomem *rom_start)
u8 temp_byte = 0xFF; u8 temp_byte = 0xFF;
u32 rc; u32 rc;
if (!check_for_compaq_ROM(rom_start)) { if (!check_for_compaq_ROM(rom_start))
return -ENODEV; return -ENODEV;
}
available = 1024; available = 1024;
...@@ -250,9 +249,8 @@ static u32 store_HRT (void __iomem *rom_start) ...@@ -250,9 +249,8 @@ static u32 store_HRT (void __iomem *rom_start)
available = 1024; available = 1024;
if (!check_for_compaq_ROM(rom_start)) { if (!check_for_compaq_ROM(rom_start))
return(1); return(1);
}
buffer = (u32*) evbuffer; buffer = (u32*) evbuffer;
...@@ -427,9 +425,9 @@ static u32 store_HRT (void __iomem *rom_start) ...@@ -427,9 +425,9 @@ static u32 store_HRT (void __iomem *rom_start)
void compaq_nvram_init (void __iomem *rom_start) void compaq_nvram_init (void __iomem *rom_start)
{ {
if (rom_start) { if (rom_start)
compaq_int15_entry_point = (rom_start + ROM_INT15_PHY_ADDR - ROM_PHY_ADDR); compaq_int15_entry_point = (rom_start + ROM_INT15_PHY_ADDR - ROM_PHY_ADDR);
}
dbg("int15 entry = %p\n", compaq_int15_entry_point); dbg("int15 entry = %p\n", compaq_int15_entry_point);
/* initialize our int15 lock */ /* initialize our int15 lock */
...@@ -661,9 +659,8 @@ int compaq_nvram_store (void __iomem *rom_start) ...@@ -661,9 +659,8 @@ int compaq_nvram_store (void __iomem *rom_start)
if (evbuffer_init) { if (evbuffer_init) {
rc = store_HRT(rom_start); rc = store_HRT(rom_start);
if (rc) { if (rc)
err(msg_unable_to_save); err(msg_unable_to_save);
}
} }
return rc; return rc;
} }
......
...@@ -1199,9 +1199,8 @@ int ibmphp_do_disable_slot(struct slot *slot_cur) ...@@ -1199,9 +1199,8 @@ int ibmphp_do_disable_slot(struct slot *slot_cur)
debug("DISABLING SLOT...\n"); debug("DISABLING SLOT...\n");
if ((slot_cur == NULL) || (slot_cur->ctrl == NULL)) { if ((slot_cur == NULL) || (slot_cur->ctrl == NULL))
return -ENODEV; return -ENODEV;
}
flag = slot_cur->flag; flag = slot_cur->flag;
slot_cur->flag = 1; slot_cur->flag = 1;
...@@ -1355,9 +1354,8 @@ static int __init ibmphp_init(void) ...@@ -1355,9 +1354,8 @@ static int __init ibmphp_init(void)
} }
ibmphp_print_test(); ibmphp_print_test();
if ((rc = ibmphp_hpc_start_poll_thread())) { if ((rc = ibmphp_hpc_start_poll_thread()))
goto error; goto error;
}
exit: exit:
return rc; return rc;
......
...@@ -215,9 +215,8 @@ static void __init print_ebda_hpc (void) ...@@ -215,9 +215,8 @@ static void __init print_ebda_hpc (void)
debug ("%s - cap of the slot: %x\n", __func__, hpc_ptr->slots[index].slot_cap); debug ("%s - cap of the slot: %x\n", __func__, hpc_ptr->slots[index].slot_cap);
} }
for (index = 0; index < hpc_ptr->bus_count; index++) { for (index = 0; index < hpc_ptr->bus_count; index++)
debug ("%s - bus# of each bus controlled by this ctlr: %x\n", __func__, hpc_ptr->buses[index].bus_num); debug ("%s - bus# of each bus controlled by this ctlr: %x\n", __func__, hpc_ptr->buses[index].bus_num);
}
debug ("%s - type of hpc: %x\n", __func__, hpc_ptr->ctlr_type); debug ("%s - type of hpc: %x\n", __func__, hpc_ptr->ctlr_type);
switch (hpc_ptr->ctlr_type) { switch (hpc_ptr->ctlr_type) {
......
...@@ -997,9 +997,8 @@ static int process_changeinstatus (struct slot *pslot, struct slot *poldslot) ...@@ -997,9 +997,8 @@ static int process_changeinstatus (struct slot *pslot, struct slot *poldslot)
rc = ibmphp_do_disable_slot (pslot); rc = ibmphp_do_disable_slot (pslot);
} }
if (update || disable) { if (update || disable)
ibmphp_update_slot_info (pslot); ibmphp_update_slot_info (pslot);
}
debug ("%s - Exit rc[%d] disable[%x] update[%x]\n", __func__, rc, disable, update); debug ("%s - Exit rc[%d] disable[%x] update[%x]\n", __func__, rc, disable, update);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment