Commit 67873d4e authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

[media] use v4l2_mc_usb_media_device_init() on most USB devices

Except for the usbuvc driver (with has an embedded media_device
struct on it), the other drivers have a pointer to media_device.

On those drivers, replace their own implementation for the core
one. That warrants that those subdev drivers will fill the
media_device info the same way.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent bb07bd6b
...@@ -191,23 +191,12 @@ static int au0828_media_device_init(struct au0828_dev *dev, ...@@ -191,23 +191,12 @@ static int au0828_media_device_init(struct au0828_dev *dev,
#ifdef CONFIG_MEDIA_CONTROLLER #ifdef CONFIG_MEDIA_CONTROLLER
struct media_device *mdev; struct media_device *mdev;
mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
if (!mdev)
return -ENOMEM;
mdev->dev = &udev->dev;
if (!dev->board.name) if (!dev->board.name)
strlcpy(mdev->model, "unknown au0828", sizeof(mdev->model)); mdev = v4l2_mc_usb_media_device_init(udev, "unknown au0828");
else else
strlcpy(mdev->model, dev->board.name, sizeof(mdev->model)); mdev = v4l2_mc_usb_media_device_init(udev, dev->board.name);
if (udev->serial) if (!mdev)
strlcpy(mdev->serial, udev->serial, sizeof(mdev->serial)); return -ENOMEM;
strcpy(mdev->bus_info, udev->devpath);
mdev->hw_revision = le16_to_cpu(udev->descriptor.bcdDevice);
mdev->driver_version = LINUX_VERSION_CODE;
media_device_init(mdev);
dev->media_dev = mdev; dev->media_dev = mdev;
#endif #endif
......
...@@ -1212,20 +1212,10 @@ static int cx231xx_media_device_init(struct cx231xx *dev, ...@@ -1212,20 +1212,10 @@ static int cx231xx_media_device_init(struct cx231xx *dev,
#ifdef CONFIG_MEDIA_CONTROLLER #ifdef CONFIG_MEDIA_CONTROLLER
struct media_device *mdev; struct media_device *mdev;
mdev = kzalloc(sizeof(*mdev), GFP_KERNEL); mdev = v4l2_mc_usb_media_device_init(udev, dev->board.name);
if (!mdev) if (!mdev)
return -ENOMEM; return -ENOMEM;
mdev->dev = dev->dev;
strlcpy(mdev->model, dev->board.name, sizeof(mdev->model));
if (udev->serial)
strlcpy(mdev->serial, udev->serial, sizeof(mdev->serial));
strcpy(mdev->bus_info, udev->devpath);
mdev->hw_revision = le16_to_cpu(udev->descriptor.bcdDevice);
mdev->driver_version = LINUX_VERSION_CODE;
media_device_init(mdev);
dev->media_dev = mdev; dev->media_dev = mdev;
#endif #endif
return 0; return 0;
......
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
*/ */
#include "dvb_usb_common.h" #include "dvb_usb_common.h"
#include <media/v4l2-mc.h>
static int dvb_usbv2_disable_rc_polling; static int dvb_usbv2_disable_rc_polling;
module_param_named(disable_rc_polling, dvb_usbv2_disable_rc_polling, int, 0644); module_param_named(disable_rc_polling, dvb_usbv2_disable_rc_polling, int, 0644);
...@@ -407,20 +408,10 @@ static int dvb_usbv2_media_device_init(struct dvb_usb_adapter *adap) ...@@ -407,20 +408,10 @@ static int dvb_usbv2_media_device_init(struct dvb_usb_adapter *adap)
struct dvb_usb_device *d = adap_to_d(adap); struct dvb_usb_device *d = adap_to_d(adap);
struct usb_device *udev = d->udev; struct usb_device *udev = d->udev;
mdev = kzalloc(sizeof(*mdev), GFP_KERNEL); mdev = v4l2_mc_usb_media_device_init(udev, d->name);
if (!mdev) if (!mdev)
return -ENOMEM; return -ENOMEM;
mdev->dev = &udev->dev;
strlcpy(mdev->model, d->name, sizeof(mdev->model));
if (udev->serial)
strlcpy(mdev->serial, udev->serial, sizeof(mdev->serial));
strcpy(mdev->bus_info, udev->devpath);
mdev->hw_revision = le16_to_cpu(udev->descriptor.bcdDevice);
mdev->driver_version = LINUX_VERSION_CODE;
media_device_init(mdev);
dvb_register_media_controller(&adap->dvb_adap, mdev); dvb_register_media_controller(&adap->dvb_adap, mdev);
dev_info(&d->udev->dev, "media controller created\n"); dev_info(&d->udev->dev, "media controller created\n");
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
* linux-dvb API. * linux-dvb API.
*/ */
#include "dvb-usb-common.h" #include "dvb-usb-common.h"
#include <media/v4l2-mc.h>
/* does the complete input transfer handling */ /* does the complete input transfer handling */
static int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff) static int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff)
...@@ -102,19 +103,7 @@ static int dvb_usb_media_device_init(struct dvb_usb_adapter *adap) ...@@ -102,19 +103,7 @@ static int dvb_usb_media_device_init(struct dvb_usb_adapter *adap)
struct dvb_usb_device *d = adap->dev; struct dvb_usb_device *d = adap->dev;
struct usb_device *udev = d->udev; struct usb_device *udev = d->udev;
mdev = kzalloc(sizeof(*mdev), GFP_KERNEL); mdev = v4l2_mc_usb_media_device_init(udev, d->desc->name);
if (!mdev)
return -ENOMEM;
mdev->dev = &udev->dev;
strlcpy(mdev->model, d->desc->name, sizeof(mdev->model));
if (udev->serial)
strlcpy(mdev->serial, udev->serial, sizeof(mdev->serial));
strcpy(mdev->bus_info, udev->devpath);
mdev->hw_revision = le16_to_cpu(udev->descriptor.bcdDevice);
mdev->driver_version = LINUX_VERSION_CODE;
media_device_init(mdev);
dvb_register_media_controller(&adap->dvb_adap, mdev); dvb_register_media_controller(&adap->dvb_adap, mdev);
......
...@@ -3019,24 +3019,17 @@ static int em28xx_media_device_init(struct em28xx *dev, ...@@ -3019,24 +3019,17 @@ static int em28xx_media_device_init(struct em28xx *dev,
#ifdef CONFIG_MEDIA_CONTROLLER #ifdef CONFIG_MEDIA_CONTROLLER
struct media_device *mdev; struct media_device *mdev;
mdev = kzalloc(sizeof(*mdev), GFP_KERNEL); if (udev->product) {
mdev = v4l2_mc_usb_media_device_init(udev, udev->product);
} else if (udev->manufacturer) {
mdev = v4l2_mc_usb_media_device_init(udev, udev->manufacturer);
} else {
mdev = v4l2_mc_usb_media_device_init(udev, dev->name);
}
if (!mdev) if (!mdev)
return -ENOMEM; return -ENOMEM;
mdev->dev = &udev->dev;
if (!dev->name)
strlcpy(mdev->model, "unknown em28xx", sizeof(mdev->model));
else
strlcpy(mdev->model, dev->name, sizeof(mdev->model));
if (udev->serial)
strlcpy(mdev->serial, udev->serial, sizeof(mdev->serial));
strcpy(mdev->bus_info, udev->devpath);
mdev->hw_revision = le16_to_cpu(udev->descriptor.bcdDevice);
mdev->driver_version = LINUX_VERSION_CODE;
media_device_init(mdev);
dev->media_dev = mdev; dev->media_dev = mdev;
#endif #endif
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment