Commit 68227c03 authored by Mateusz Jurczyk's avatar Mateusz Jurczyk Committed by Miklos Szeredi

fuse: initialize the flock flag in fuse_file on allocation

Before the patch, the flock flag could remain uninitialized for the
lifespan of the fuse_file allocation. Unless set to true in
fuse_file_flock(), it would remain in an indeterminate state until read in
an if statement in fuse_release_common(). This could consequently lead to
taking an unexpected branch in the code.

The bug was discovered by a runtime instrumentation designed to detect use
of uninitialized memory in the kernel.
Signed-off-by: default avatarMateusz Jurczyk <mjurczyk@google.com>
Fixes: 37fb3a30 ("fuse: fix flock")
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 2ea659a9
...@@ -46,7 +46,7 @@ struct fuse_file *fuse_file_alloc(struct fuse_conn *fc) ...@@ -46,7 +46,7 @@ struct fuse_file *fuse_file_alloc(struct fuse_conn *fc)
{ {
struct fuse_file *ff; struct fuse_file *ff;
ff = kmalloc(sizeof(struct fuse_file), GFP_KERNEL); ff = kzalloc(sizeof(struct fuse_file), GFP_KERNEL);
if (unlikely(!ff)) if (unlikely(!ff))
return NULL; return NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment