Commit 68b7587b authored by Axel Lin's avatar Axel Lin Committed by Bartosz Golaszewski

gpio: altera-a10sr: Trivial coding style fix

Change the coding style to make it does error checking first.
This also fixes checkpatch warning about line over 80 characters.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Tested by: Thor Thayer <thor.thayer@linux.intel.com>
Reviewed by: Thor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 69118452
...@@ -58,19 +58,20 @@ static void altr_a10sr_gpio_set(struct gpio_chip *chip, unsigned int offset, ...@@ -58,19 +58,20 @@ static void altr_a10sr_gpio_set(struct gpio_chip *chip, unsigned int offset,
static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc, static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,
unsigned int nr) unsigned int nr)
{ {
if (nr >= (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT)) if (nr < (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT))
return 0; return -EINVAL;
return -EINVAL;
return 0;
} }
static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc, static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,
unsigned int nr, int value) unsigned int nr, int value)
{ {
if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) { if (nr > (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT))
altr_a10sr_gpio_set(gc, nr, value); return -EINVAL;
return 0;
} altr_a10sr_gpio_set(gc, nr, value);
return -EINVAL; return 0;
} }
static const struct gpio_chip altr_a10sr_gc = { static const struct gpio_chip altr_a10sr_gc = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment