Commit 69dc4a5e authored by Cyrille Pitchen's avatar Cyrille Pitchen Committed by Luis Henriques

tty/serial: at91: fix error handling in atmel_serial_probe()

commit 6fbb9bdf upstream.

-EDEFER error wasn't handle properly by atmel_serial_probe().
As an example, when atmel_serial_probe() is called for the first time, we pass
the test_and_set_bit() test to check whether the port has already been
initalized. Then we call atmel_init_port(), which may return -EDEFER, possibly
returned before by clk_get(). Consequently atmel_serial_probe() used to return
this error code WITHOUT clearing the port bit in the "atmel_ports_in_use" mask.
When atmel_serial_probe() was called for the second time, it used to fail on
the test_and_set_bit() function then returning -EBUSY.

When atmel_serial_probe() fails, this patch make it clear the port bit in the
"atmel_ports_in_use" mask, if needed, before returning the error code.
Signed-off-by: default avatarCyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 5b1e6754
...@@ -2576,7 +2576,7 @@ static int atmel_serial_probe(struct platform_device *pdev) ...@@ -2576,7 +2576,7 @@ static int atmel_serial_probe(struct platform_device *pdev)
ret = atmel_init_port(port, pdev); ret = atmel_init_port(port, pdev);
if (ret) if (ret)
goto err; goto err_clear_bit;
if (!atmel_use_pdc_rx(&port->uart)) { if (!atmel_use_pdc_rx(&port->uart)) {
ret = -ENOMEM; ret = -ENOMEM;
...@@ -2637,6 +2637,8 @@ static int atmel_serial_probe(struct platform_device *pdev) ...@@ -2637,6 +2637,8 @@ static int atmel_serial_probe(struct platform_device *pdev)
clk_put(port->clk); clk_put(port->clk);
port->clk = NULL; port->clk = NULL;
} }
err_clear_bit:
clear_bit(port->uart.line, atmel_ports_in_use);
err: err:
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment