Commit 6a0d12ef authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Rafael J. Wysocki

ACPI / scan: use kstrdup_const() in acpi_add_id()

Empirically, acpi_add_id is mostly called with string literals, so
using kstrdup_const for initializing struct acpi_hardware_id::id saves
a little run-time memory and a string copy.
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 844142c3
...@@ -1184,7 +1184,7 @@ static void acpi_add_id(struct acpi_device_pnp *pnp, const char *dev_id) ...@@ -1184,7 +1184,7 @@ static void acpi_add_id(struct acpi_device_pnp *pnp, const char *dev_id)
if (!id) if (!id)
return; return;
id->id = kstrdup(dev_id, GFP_KERNEL); id->id = kstrdup_const(dev_id, GFP_KERNEL);
if (!id->id) { if (!id->id) {
kfree(id); kfree(id);
return; return;
...@@ -1322,7 +1322,7 @@ void acpi_free_pnp_ids(struct acpi_device_pnp *pnp) ...@@ -1322,7 +1322,7 @@ void acpi_free_pnp_ids(struct acpi_device_pnp *pnp)
struct acpi_hardware_id *id, *tmp; struct acpi_hardware_id *id, *tmp;
list_for_each_entry_safe(id, tmp, &pnp->ids, list) { list_for_each_entry_safe(id, tmp, &pnp->ids, list) {
kfree(id->id); kfree_const(id->id);
kfree(id); kfree(id);
} }
kfree(pnp->unique_id); kfree(pnp->unique_id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment