Commit 6abe4a87 authored by Boaz Harrosh's avatar Boaz Harrosh

exofs: Fix CRASH on very early IO errors.

If at exofs_fill_super() we had an early termination
do to any error, like an IO error while reading the
super-block. We would crash inside exofs_free_sbi().

This is because sbi->oc.numdevs was set to 1, before
we actually have a device table at all.

Fix it by moving the sbi->oc.numdevs = 1 to after the
allocation of the device table.
Reported-by: default avatarJohannes Schild <JSchild@gmx.de>

Stable: This is a bug since v3.2.0
CC: Stable Tree <stable@kernel.org>
Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
parent 36be5051
...@@ -745,7 +745,6 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) ...@@ -745,7 +745,6 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent)
sbi->one_comp.obj.partition = opts->pid; sbi->one_comp.obj.partition = opts->pid;
sbi->one_comp.obj.id = 0; sbi->one_comp.obj.id = 0;
exofs_make_credential(sbi->one_comp.cred, &sbi->one_comp.obj); exofs_make_credential(sbi->one_comp.cred, &sbi->one_comp.obj);
sbi->oc.numdevs = 1;
sbi->oc.single_comp = EC_SINGLE_COMP; sbi->oc.single_comp = EC_SINGLE_COMP;
sbi->oc.comps = &sbi->one_comp; sbi->oc.comps = &sbi->one_comp;
...@@ -804,6 +803,7 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) ...@@ -804,6 +803,7 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent)
goto free_sbi; goto free_sbi;
ore_comp_set_dev(&sbi->oc, 0, od); ore_comp_set_dev(&sbi->oc, 0, od);
sbi->oc.numdevs = 1;
} }
__sbi_read_stats(sbi); __sbi_read_stats(sbi);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment