Commit 6b00a76a authored by Alex Elder's avatar Alex Elder Committed by Jakub Kicinski

net: ipa: don't thaw channel if error starting

If an error occurs starting a channel, don't "thaw" it.
We should assume the channel remains in a non-started state.

Update the comment in gsi_channel_stop(); calls to this function
are no longer retried.
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Acked-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 097b9146
......@@ -885,7 +885,9 @@ int gsi_channel_start(struct gsi *gsi, u32 channel_id)
mutex_unlock(&gsi->mutex);
gsi_channel_thaw(channel);
/* Thaw the channel if successful */
if (!ret)
gsi_channel_thaw(channel);
return ret;
}
......@@ -910,7 +912,7 @@ int gsi_channel_stop(struct gsi *gsi, u32 channel_id)
mutex_unlock(&gsi->mutex);
/* Thaw the channel if we need to retry (or on error) */
/* Re-thaw the channel if an error occurred while stopping */
if (ret)
gsi_channel_thaw(channel);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment