Commit 6b8ac638 authored by Eric Anholt's avatar Eric Anholt

drm/vc4: Return -EINVAL on the overflow checks failing.

By failing to set the errno, we'd continue on to trying to set up the
RCL, and then oops on trying to dereference the tile_bo that binning
validation should have set up.
Reported-by: default avatarIngo Molnar <mingo@kernel.org>
Signed-off-by: default avatarEric Anholt <eric@anholt.net>
Fixes: d5b1a78a ("drm/vc4: Add support for drawing 3D frames.")
parent 0f2ff82e
...@@ -601,6 +601,7 @@ vc4_get_bcl(struct drm_device *dev, struct vc4_exec_info *exec) ...@@ -601,6 +601,7 @@ vc4_get_bcl(struct drm_device *dev, struct vc4_exec_info *exec)
sizeof(struct vc4_shader_state)) || sizeof(struct vc4_shader_state)) ||
temp_size < exec_size) { temp_size < exec_size) {
DRM_ERROR("overflow in exec arguments\n"); DRM_ERROR("overflow in exec arguments\n");
ret = -EINVAL;
goto fail; goto fail;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment