Commit 6bcb20c7 authored by Andrea Merello's avatar Andrea Merello Committed by John W. Linville

rtl8180: add parentheses to REG_ADDR macros

Parentheses are missing around the macro argument, causing the
macro possibly not to work passing certain expressions as
arguments.

This should not cause any issues with current code, however it's
worth to add them, as a good practice, and to eventually avoid
future bugs.
Suggested-by: default avatarDave Kilroy <kilroyd@googlemail.com>
Signed-off-by: default avatarAndrea Merello <andrea.merello@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 1c3fb9b8
...@@ -334,9 +334,9 @@ struct rtl818x_csr { ...@@ -334,9 +334,9 @@ struct rtl818x_csr {
* I don't like to introduce a ton of "reserved".. * I don't like to introduce a ton of "reserved"..
* They are for RTL8187SE * They are for RTL8187SE
*/ */
#define REG_ADDR1(addr) ((u8 __iomem *)priv->map + addr) #define REG_ADDR1(addr) ((u8 __iomem *)priv->map + (addr))
#define REG_ADDR2(addr) ((__le16 __iomem *)priv->map + (addr >> 1)) #define REG_ADDR2(addr) ((__le16 __iomem *)priv->map + ((addr) >> 1))
#define REG_ADDR4(addr) ((__le32 __iomem *)priv->map + (addr >> 2)) #define REG_ADDR4(addr) ((__le32 __iomem *)priv->map + ((addr) >> 2))
#define FEMR_SE REG_ADDR2(0x1D4) #define FEMR_SE REG_ADDR2(0x1D4)
#define ARFR REG_ADDR2(0x1E0) #define ARFR REG_ADDR2(0x1E0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment