Commit 6ca3ee2f authored by Sunil Goutham's avatar Sunil Goutham Committed by David S. Miller

octeontx2-af: Improve register polling loop

Instead of looping on a integer timeout, use time_before(jiffies),
so that maximum poll time is capped.
Signed-off-by: default avatarSunil Goutham <sgoutham@marvell.com>
Suggested-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 53e50a6e
...@@ -47,18 +47,18 @@ MODULE_DEVICE_TABLE(pci, rvu_id_table); ...@@ -47,18 +47,18 @@ MODULE_DEVICE_TABLE(pci, rvu_id_table);
*/ */
int rvu_poll_reg(struct rvu *rvu, u64 block, u64 offset, u64 mask, bool zero) int rvu_poll_reg(struct rvu *rvu, u64 block, u64 offset, u64 mask, bool zero)
{ {
unsigned long timeout = jiffies + usecs_to_jiffies(100);
void __iomem *reg; void __iomem *reg;
int timeout = 100;
u64 reg_val; u64 reg_val;
reg = rvu->afreg_base + ((block << 28) | offset); reg = rvu->afreg_base + ((block << 28) | offset);
while (timeout) { while (time_before(jiffies, timeout)) {
reg_val = readq(reg); reg_val = readq(reg);
if (zero && !(reg_val & mask)) if (zero && !(reg_val & mask))
return 0; return 0;
if (!zero && (reg_val & mask)) if (!zero && (reg_val & mask))
return 0; return 0;
usleep_range(1, 2); usleep_range(1, 5);
timeout--; timeout--;
} }
return -EBUSY; return -EBUSY;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment