Commit 6ccd1c5d authored by Alexander Drozdov's avatar Alexander Drozdov Committed by Luis Henriques

ipv4: ip_check_defrag should not assume that skb_network_offset is zero

commit 3e32e733 upstream.

ip_check_defrag() may be used by af_packet to defragment outgoing packets.
skb_network_offset() of af_packet's outgoing packets is not zero.
Signed-off-by: default avatarAlexander Drozdov <al.drozdov@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 03734c78
...@@ -680,27 +680,30 @@ EXPORT_SYMBOL(ip_defrag); ...@@ -680,27 +680,30 @@ EXPORT_SYMBOL(ip_defrag);
struct sk_buff *ip_check_defrag(struct sk_buff *skb, u32 user) struct sk_buff *ip_check_defrag(struct sk_buff *skb, u32 user)
{ {
struct iphdr iph; struct iphdr iph;
int netoff;
u32 len; u32 len;
if (skb->protocol != htons(ETH_P_IP)) if (skb->protocol != htons(ETH_P_IP))
return skb; return skb;
if (skb_copy_bits(skb, 0, &iph, sizeof(iph)) < 0) netoff = skb_network_offset(skb);
if (skb_copy_bits(skb, netoff, &iph, sizeof(iph)) < 0)
return skb; return skb;
if (iph.ihl < 5 || iph.version != 4) if (iph.ihl < 5 || iph.version != 4)
return skb; return skb;
len = ntohs(iph.tot_len); len = ntohs(iph.tot_len);
if (skb->len < len || len < (iph.ihl * 4)) if (skb->len < netoff + len || len < (iph.ihl * 4))
return skb; return skb;
if (ip_is_fragment(&iph)) { if (ip_is_fragment(&iph)) {
skb = skb_share_check(skb, GFP_ATOMIC); skb = skb_share_check(skb, GFP_ATOMIC);
if (skb) { if (skb) {
if (!pskb_may_pull(skb, iph.ihl*4)) if (!pskb_may_pull(skb, netoff + iph.ihl * 4))
return skb; return skb;
if (pskb_trim_rcsum(skb, len)) if (pskb_trim_rcsum(skb, netoff + len))
return skb; return skb;
memset(IPCB(skb), 0, sizeof(struct inet_skb_parm)); memset(IPCB(skb), 0, sizeof(struct inet_skb_parm));
if (ip_defrag(skb, user)) if (ip_defrag(skb, user))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment