Commit 6cf0a91e authored by Jean Delvare's avatar Jean Delvare

hwmon: Avoid initializing the same field twice

All hwmon drivers allocate their data structure with some form of
kzalloc, so setting data fields to zero explicitly is a waste of time.
Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 5b581575
...@@ -1115,7 +1115,6 @@ asc7621_probe(struct i2c_client *client, const struct i2c_device_id *id) ...@@ -1115,7 +1115,6 @@ asc7621_probe(struct i2c_client *client, const struct i2c_device_id *id)
return -ENOMEM; return -ENOMEM;
i2c_set_clientdata(client, data); i2c_set_clientdata(client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
/* Initialize the asc7621 chip */ /* Initialize the asc7621 chip */
......
...@@ -353,8 +353,6 @@ static int atxp1_probe(struct i2c_client *new_client, ...@@ -353,8 +353,6 @@ static int atxp1_probe(struct i2c_client *new_client,
data->vrm = vid_which_vrm(); data->vrm = vid_which_vrm();
i2c_set_clientdata(new_client, data); i2c_set_clientdata(new_client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
/* Register sysfs hooks */ /* Register sysfs hooks */
......
...@@ -348,7 +348,6 @@ static int lm77_probe(struct i2c_client *client, const struct i2c_device_id *id) ...@@ -348,7 +348,6 @@ static int lm77_probe(struct i2c_client *client, const struct i2c_device_id *id)
return -ENOMEM; return -ENOMEM;
i2c_set_clientdata(client, data); i2c_set_clientdata(client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
/* Initialize the LM77 chip */ /* Initialize the LM77 chip */
......
...@@ -349,7 +349,6 @@ static int lm83_probe(struct i2c_client *new_client, ...@@ -349,7 +349,6 @@ static int lm83_probe(struct i2c_client *new_client,
return -ENOMEM; return -ENOMEM;
i2c_set_clientdata(new_client, data); i2c_set_clientdata(new_client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
/* /*
......
...@@ -903,7 +903,6 @@ static int lm87_probe(struct i2c_client *client, const struct i2c_device_id *id) ...@@ -903,7 +903,6 @@ static int lm87_probe(struct i2c_client *client, const struct i2c_device_id *id)
return -ENOMEM; return -ENOMEM;
i2c_set_clientdata(client, data); i2c_set_clientdata(client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
/* Initialize the LM87 chip */ /* Initialize the LM87 chip */
......
...@@ -380,7 +380,6 @@ static int lm92_probe(struct i2c_client *new_client, ...@@ -380,7 +380,6 @@ static int lm92_probe(struct i2c_client *new_client,
return -ENOMEM; return -ENOMEM;
i2c_set_clientdata(new_client, data); i2c_set_clientdata(new_client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
/* Initialize the chipset */ /* Initialize the chipset */
......
...@@ -2754,7 +2754,6 @@ static int lm93_probe(struct i2c_client *client, ...@@ -2754,7 +2754,6 @@ static int lm93_probe(struct i2c_client *client,
i2c_set_clientdata(client, data); i2c_set_clientdata(client, data);
/* housekeeping */ /* housekeeping */
data->valid = 0;
data->update = update; data->update = update;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
......
...@@ -273,7 +273,6 @@ static int max1619_probe(struct i2c_client *new_client, ...@@ -273,7 +273,6 @@ static int max1619_probe(struct i2c_client *new_client,
return -ENOMEM; return -ENOMEM;
i2c_set_clientdata(new_client, data); i2c_set_clientdata(new_client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
/* Initialize the MAX1619 chip */ /* Initialize the MAX1619 chip */
......
...@@ -1376,7 +1376,6 @@ w83792d_probe(struct i2c_client *client, const struct i2c_device_id *id) ...@@ -1376,7 +1376,6 @@ w83792d_probe(struct i2c_client *client, const struct i2c_device_id *id)
return -ENOMEM; return -ENOMEM;
i2c_set_clientdata(client, data); i2c_set_clientdata(client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
err = w83792d_detect_subclients(client); err = w83792d_detect_subclients(client);
......
...@@ -188,12 +188,8 @@ static int w83l785ts_probe(struct i2c_client *client, ...@@ -188,12 +188,8 @@ static int w83l785ts_probe(struct i2c_client *client,
return -ENOMEM; return -ENOMEM;
i2c_set_clientdata(client, data); i2c_set_clientdata(client, data);
data->valid = 0;
mutex_init(&data->update_lock); mutex_init(&data->update_lock);
/* Default values in case the first read fails (unlikely). */
data->temp[1] = data->temp[0] = 0;
/* /*
* Initialize the W83L785TS chip * Initialize the W83L785TS chip
* Nothing yet, assume it is already started. * Nothing yet, assume it is already started.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment