Commit 6daf6531 authored by Maciej W. Rozycki's avatar Maciej W. Rozycki Committed by David S. Miller

PHYLIB: fix an interrupt loop potential when halting

Ensure the PHY_HALTED state is not entered with the IRQ asserted as it
could lead to an interrupt loop.

There is a small window in phy_stop(), where the state of the PHY machine
indicates it has been halted, but its interrupt output might still be
unmasked.  If an interrupt goes active right at this moment it will loop as
the phy_interrupt() handler exits immediately with IRQ_NONE if the halted
state is seen.  It is unsafe to extend the phydev spinlock to cover
phy_interrupt().  It is safe to swap the order of the actions though as all
the competing places to unmask the interrupt output of the PHY, which are
phy_change() and phy_timer() are already covered with the lock as is the
sequence in question.
Signed-off-by: default avatarMaciej W. Rozycki <macro@linux-mips.org>
Cc: Andy Fleming <afleming@freescale.com>
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 0ac49527
...@@ -737,8 +737,6 @@ void phy_stop(struct phy_device *phydev) ...@@ -737,8 +737,6 @@ void phy_stop(struct phy_device *phydev)
if (PHY_HALTED == phydev->state) if (PHY_HALTED == phydev->state)
goto out_unlock; goto out_unlock;
phydev->state = PHY_HALTED;
if (phydev->irq != PHY_POLL) { if (phydev->irq != PHY_POLL) {
/* Disable PHY Interrupts */ /* Disable PHY Interrupts */
phy_config_interrupt(phydev, PHY_INTERRUPT_DISABLED); phy_config_interrupt(phydev, PHY_INTERRUPT_DISABLED);
...@@ -747,6 +745,8 @@ void phy_stop(struct phy_device *phydev) ...@@ -747,6 +745,8 @@ void phy_stop(struct phy_device *phydev)
phy_clear_interrupt(phydev); phy_clear_interrupt(phydev);
} }
phydev->state = PHY_HALTED;
out_unlock: out_unlock:
spin_unlock_bh(&phydev->lock); spin_unlock_bh(&phydev->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment