Commit 6e700f06 authored by Jerome Brunet's avatar Jerome Brunet Committed by Mark Brown

ASoC: meson: aiu: fix irq registration

The aiu stored the irq in an unsigned integer which may have discarded an
error returned by platform_get_irq_byname(). This is incorrect and should
have been a signed integer.

Also drop the irq error traces from the probe function as this is already
done by platform_get_irq_byname().

Fixes: 6ae9ca9c ("ASoC: meson: aiu: add i2s and spdif support")
Reported-by: default avatarkbuild test robot <lkp@intel.com>
Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20200214131350.337968-4-jbrunet@baylibre.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 269f0017
...@@ -314,16 +314,12 @@ static int aiu_probe(struct platform_device *pdev) ...@@ -314,16 +314,12 @@ static int aiu_probe(struct platform_device *pdev)
} }
aiu->i2s.irq = platform_get_irq_byname(pdev, "i2s"); aiu->i2s.irq = platform_get_irq_byname(pdev, "i2s");
if (aiu->i2s.irq < 0) { if (aiu->i2s.irq < 0)
dev_err(dev, "Can't get i2s irq\n");
return aiu->i2s.irq; return aiu->i2s.irq;
}
aiu->spdif.irq = platform_get_irq_byname(pdev, "spdif"); aiu->spdif.irq = platform_get_irq_byname(pdev, "spdif");
if (aiu->spdif.irq < 0) { if (aiu->spdif.irq < 0)
dev_err(dev, "Can't get spdif irq\n");
return aiu->spdif.irq; return aiu->spdif.irq;
}
ret = aiu_clk_get(dev); ret = aiu_clk_get(dev);
if (ret) if (ret)
......
...@@ -26,7 +26,7 @@ enum aiu_clk_ids { ...@@ -26,7 +26,7 @@ enum aiu_clk_ids {
struct aiu_interface { struct aiu_interface {
struct clk_bulk_data *clks; struct clk_bulk_data *clks;
unsigned int clk_num; unsigned int clk_num;
unsigned int irq; int irq;
}; };
struct aiu { struct aiu {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment