Commit 6e8e9d80 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Russell King

[PCMCIA] kill off last remains of the release timer

update the previously missed atmel_cs driver and kill the struct
member.
parent f0146a91
...@@ -39,7 +39,6 @@ ...@@ -39,7 +39,6 @@
#include <linux/ptrace.h> #include <linux/ptrace.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/string.h> #include <linux/string.h>
#include <linux/timer.h>
#include <linux/netdevice.h> #include <linux/netdevice.h>
#include <linux/moduleparam.h> #include <linux/moduleparam.h>
#include <linux/device.h> #include <linux/device.h>
...@@ -108,7 +107,7 @@ void stop_atmel_card( struct net_device *, int ); ...@@ -108,7 +107,7 @@ void stop_atmel_card( struct net_device *, int );
int reset_atmel_card( struct net_device * ); int reset_atmel_card( struct net_device * );
static void atmel_config(dev_link_t *link); static void atmel_config(dev_link_t *link);
static void atmel_release(u_long arg); static void atmel_release(dev_link_t *link);
static int atmel_event(event_t event, int priority, static int atmel_event(event_t event, int priority,
event_callback_args_t *args); event_callback_args_t *args);
...@@ -222,9 +221,6 @@ static dev_link_t *atmel_attach(void) ...@@ -222,9 +221,6 @@ static dev_link_t *atmel_attach(void)
return NULL; return NULL;
} }
memset(link, 0, sizeof(struct dev_link_t)); memset(link, 0, sizeof(struct dev_link_t));
init_timer(&link->release);
link->release.function = &atmel_release;
link->release.data = (u_long)link;
/* Interrupt setup */ /* Interrupt setup */
link->irq.Attributes = IRQ_TYPE_EXCLUSIVE; link->irq.Attributes = IRQ_TYPE_EXCLUSIVE;
...@@ -300,9 +296,8 @@ static void atmel_detach(dev_link_t *link) ...@@ -300,9 +296,8 @@ static void atmel_detach(dev_link_t *link)
if (*linkp == NULL) if (*linkp == NULL)
return; return;
del_timer(&link->release);
if ( link->state & DEV_CONFIG ) { if ( link->state & DEV_CONFIG ) {
atmel_release( (int)link ); atmel_release(link);
if ( link->state & DEV_STALE_CONFIG ) { if ( link->state & DEV_STALE_CONFIG ) {
link->state |= DEV_STALE_LINK; link->state |= DEV_STALE_LINK;
return; return;
...@@ -606,9 +601,8 @@ static void atmel_config(dev_link_t *link) ...@@ -606,9 +601,8 @@ static void atmel_config(dev_link_t *link)
cs_failed: cs_failed:
cs_error(link->handle, last_fn, last_ret); cs_error(link->handle, last_fn, last_ret);
atmel_release((u_long)link); atmel_release(link);
}
} /* atmel_config */
/*====================================================================== /*======================================================================
...@@ -618,9 +612,8 @@ static void atmel_config(dev_link_t *link) ...@@ -618,9 +612,8 @@ static void atmel_config(dev_link_t *link)
======================================================================*/ ======================================================================*/
static void atmel_release(u_long arg) static void atmel_release(dev_link_t *link)
{ {
dev_link_t *link = (dev_link_t *)arg;
struct net_device *dev = ((local_info_t*)link->priv)->eth_dev; struct net_device *dev = ((local_info_t*)link->priv)->eth_dev;
DEBUG(0, "atmel_release(0x%p)\n", link); DEBUG(0, "atmel_release(0x%p)\n", link);
...@@ -639,8 +632,7 @@ static void atmel_release(u_long arg) ...@@ -639,8 +632,7 @@ static void atmel_release(u_long arg)
if (link->irq.AssignedIRQ) if (link->irq.AssignedIRQ)
CardServices(ReleaseIRQ, link->handle, &link->irq); CardServices(ReleaseIRQ, link->handle, &link->irq);
link->state &= ~DEV_CONFIG; link->state &= ~DEV_CONFIG;
}
} /* atmel_release */
/*====================================================================== /*======================================================================
...@@ -667,7 +659,7 @@ static int atmel_event(event_t event, int priority, ...@@ -667,7 +659,7 @@ static int atmel_event(event_t event, int priority,
link->state &= ~DEV_PRESENT; link->state &= ~DEV_PRESENT;
if (link->state & DEV_CONFIG) { if (link->state & DEV_CONFIG) {
netif_device_detach(local->eth_dev); netif_device_detach(local->eth_dev);
mod_timer(&link->release, jiffies + HZ/20); atmel_release(link);
} }
break; break;
case CS_EVENT_CARD_INSERTION: case CS_EVENT_CARD_INSERTION:
...@@ -719,7 +711,7 @@ static void atmel_cs_cleanup(void) ...@@ -719,7 +711,7 @@ static void atmel_cs_cleanup(void)
/* XXX: this really needs to move into generic code.. */ /* XXX: this really needs to move into generic code.. */
while (dev_list != NULL) { while (dev_list != NULL) {
if (dev_list->state & DEV_CONFIG) if (dev_list->state & DEV_CONFIG)
atmel_release((u_long)dev_list); atmel_release(dev_list);
atmel_detach(dev_list); atmel_detach(dev_list);
} }
} }
......
...@@ -118,7 +118,6 @@ typedef struct dev_link_t { ...@@ -118,7 +118,6 @@ typedef struct dev_link_t {
dev_node_t *dev; dev_node_t *dev;
u_int state, open; u_int state, open;
wait_queue_head_t pending; wait_queue_head_t pending;
struct timer_list release;
client_handle_t handle; client_handle_t handle;
io_req_t io; io_req_t io;
irq_req_t irq; irq_req_t irq;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment