Commit 6ea671a1 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Paul Mackerras

[PATCH] powerpc: tidy-up of_register_driver()/driver_register() return values

Remove the assumption that driver_register() returns the number of devices
bound to the driver.  In fact, it returns zero for success or a negative
error value.

Nobody uses the return value of of_register_driver() anyway.
Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent 57ae595f
...@@ -147,15 +147,12 @@ postcore_initcall(of_bus_driver_init); ...@@ -147,15 +147,12 @@ postcore_initcall(of_bus_driver_init);
int of_register_driver(struct of_platform_driver *drv) int of_register_driver(struct of_platform_driver *drv)
{ {
int count = 0;
/* initialize common driver fields */ /* initialize common driver fields */
drv->driver.name = drv->name; drv->driver.name = drv->name;
drv->driver.bus = &of_platform_bus_type; drv->driver.bus = &of_platform_bus_type;
/* register with core */ /* register with core */
count = driver_register(&drv->driver); return driver_register(&drv->driver);
return count ? count : 1;
} }
void of_unregister_driver(struct of_platform_driver *drv) void of_unregister_driver(struct of_platform_driver *drv)
......
...@@ -629,8 +629,6 @@ static struct of_platform_driver smu_of_platform_driver = ...@@ -629,8 +629,6 @@ static struct of_platform_driver smu_of_platform_driver =
static int __init smu_init_sysfs(void) static int __init smu_init_sysfs(void)
{ {
int rc;
/* /*
* Due to sysfs bogosity, a sysdev is not a real device, so * Due to sysfs bogosity, a sysdev is not a real device, so
* we should in fact create both if we want sysdev semantics * we should in fact create both if we want sysdev semantics
...@@ -639,7 +637,7 @@ static int __init smu_init_sysfs(void) ...@@ -639,7 +637,7 @@ static int __init smu_init_sysfs(void)
* I'm a bit too far from figuring out how that works with those * I'm a bit too far from figuring out how that works with those
* new chipsets, but that will come back and bite us * new chipsets, but that will come back and bite us
*/ */
rc = of_register_driver(&smu_of_platform_driver); of_register_driver(&smu_of_platform_driver);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment