Commit 6eaeda12 authored by Geliang Tang's avatar Geliang Tang Committed by David S. Miller

selftests: mptcp: netlink: drop disable=SC2086

Now there are only a few of variables are not using double quotes.
Modifying them, then "shellcheck disable=SC2086" can be dropped.
Signed-off-by: default avatarGeliang Tang <tanggeliang@kylinos.cn>
Reviewed-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0cef6fca
#!/bin/bash #!/bin/bash
# SPDX-License-Identifier: GPL-2.0 # SPDX-License-Identifier: GPL-2.0
# Double quotes to prevent globbing and word splitting is recommended in new
# code but we accept it, especially because there were too many before having
# address all other issues detected by shellcheck.
#shellcheck disable=SC2086
. "$(dirname "${0}")/mptcp_lib.sh" . "$(dirname "${0}")/mptcp_lib.sh"
ret=0 ret=0
...@@ -20,14 +15,14 @@ optstring=hi ...@@ -20,14 +15,14 @@ optstring=hi
while getopts "$optstring" option;do while getopts "$optstring" option;do
case "$option" in case "$option" in
"h") "h")
usage $0 usage "$0"
exit ${KSFT_PASS} exit ${KSFT_PASS}
;; ;;
"i") "i")
mptcp_lib_set_ip_mptcp mptcp_lib_set_ip_mptcp
;; ;;
"?") "?")
usage $0 usage "$0"
exit ${KSFT_FAIL} exit ${KSFT_FAIL}
;; ;;
esac esac
...@@ -40,7 +35,7 @@ err=$(mktemp) ...@@ -40,7 +35,7 @@ err=$(mktemp)
#shellcheck disable=SC2317 #shellcheck disable=SC2317
cleanup() cleanup()
{ {
rm -f $err rm -f "${err}"
mptcp_lib_ns_exit "${ns1}" mptcp_lib_ns_exit "${ns1}"
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment