Commit 6f68794c authored by Robert Love's avatar Robert Love Committed by James Bottomley

[SCSI] fcoe: Rename out_nomod label to out_putmod

The label implies that it should be called when
there is 'nomod.' I read that to mean that the
module reference 'get' failed. However, it's only
called when the module reference 'get' succeeded.

I think it makes more sense to name the label,
'out_putmod' since it should be called when we
need to 'put' the module reference taken in the
routine before returning.
Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
Tested-by: default avatarRoss Brattain <ross.b.brattain@intel.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 7e5adcfb
...@@ -380,7 +380,7 @@ static struct fcoe_interface *fcoe_interface_create(struct net_device *netdev, ...@@ -380,7 +380,7 @@ static struct fcoe_interface *fcoe_interface_create(struct net_device *netdev,
if (!fcoe) { if (!fcoe) {
FCOE_NETDEV_DBG(netdev, "Could not allocate fcoe structure\n"); FCOE_NETDEV_DBG(netdev, "Could not allocate fcoe structure\n");
fcoe = ERR_PTR(-ENOMEM); fcoe = ERR_PTR(-ENOMEM);
goto out_nomod; goto out_putmod;
} }
dev_hold(netdev); dev_hold(netdev);
...@@ -400,12 +400,12 @@ static struct fcoe_interface *fcoe_interface_create(struct net_device *netdev, ...@@ -400,12 +400,12 @@ static struct fcoe_interface *fcoe_interface_create(struct net_device *netdev,
kfree(fcoe); kfree(fcoe);
dev_put(netdev); dev_put(netdev);
fcoe = ERR_PTR(err); fcoe = ERR_PTR(err);
goto out_nomod; goto out_putmod;
} }
goto out; goto out;
out_nomod: out_putmod:
module_put(THIS_MODULE); module_put(THIS_MODULE);
out: out:
return fcoe; return fcoe;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment