Commit 6f8cd246 authored by Dinghao Liu's avatar Dinghao Liu Committed by Linus Walleij

gpio: rcar: Fix runtime PM imbalance on error

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200522080839.32612-1-dinghao.liu@zju.edu.cnSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent c22fc62b
...@@ -250,8 +250,10 @@ static int gpio_rcar_request(struct gpio_chip *chip, unsigned offset) ...@@ -250,8 +250,10 @@ static int gpio_rcar_request(struct gpio_chip *chip, unsigned offset)
int error; int error;
error = pm_runtime_get_sync(p->dev); error = pm_runtime_get_sync(p->dev);
if (error < 0) if (error < 0) {
pm_runtime_put(p->dev);
return error; return error;
}
error = pinctrl_gpio_request(chip->base + offset); error = pinctrl_gpio_request(chip->base + offset);
if (error) if (error)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment