Commit 70096a56 authored by Matt Mackall's avatar Matt Mackall Committed by Linus Torvalds

SLOB: fix bogus ksize calculation fix

This fixes the previous fix, which was completely wrong on closer
inspection. This version has been manually tested with a user-space
test harness and generates sane values. A nearly identical patch has
been boot-tested.

The problem arose from changing how kmalloc/kfree handled alignment
padding without updating ksize to match. This brings it in sync.
Signed-off-by: default avatarMatt Mackall <mpm@selenic.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 69849375
...@@ -514,9 +514,11 @@ size_t ksize(const void *block) ...@@ -514,9 +514,11 @@ size_t ksize(const void *block)
return 0; return 0;
sp = (struct slob_page *)virt_to_page(block); sp = (struct slob_page *)virt_to_page(block);
if (slob_page(sp)) if (slob_page(sp)) {
return (((slob_t *)block - 1)->units - 1) * SLOB_UNIT; int align = max(ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN);
else unsigned int *m = (unsigned int *)(block - align);
return SLOB_UNITS(*m) * SLOB_UNIT;
} else
return sp->page.private; return sp->page.private;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment