Commit 700c17ca authored by Donglin Peng's avatar Donglin Peng Committed by Mark Brown

ASoC: use seq_file to dump the contents of dai_list,platform_list and codec_list

Now the debugfs files dais/platforms/codecs have a size limit PAGE_SIZE and
the user can not see the whole contents of dai_list/platform_list/codec_list
when they are larger than this limit.

This patch uses seq_file instead to make sure dais/platforms/codecs show the
full contents of dai_list/platform_list/codec_list.
Signed-off-by: default avatarDonglin Peng <dolinux.peng@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4fbd8d19
...@@ -349,120 +349,84 @@ static void soc_init_codec_debugfs(struct snd_soc_component *component) ...@@ -349,120 +349,84 @@ static void soc_init_codec_debugfs(struct snd_soc_component *component)
"ASoC: Failed to create codec register debugfs file\n"); "ASoC: Failed to create codec register debugfs file\n");
} }
static ssize_t codec_list_read_file(struct file *file, char __user *user_buf, static int codec_list_seq_show(struct seq_file *m, void *v)
size_t count, loff_t *ppos)
{ {
char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
ssize_t len, ret = 0;
struct snd_soc_codec *codec; struct snd_soc_codec *codec;
if (!buf)
return -ENOMEM;
mutex_lock(&client_mutex); mutex_lock(&client_mutex);
list_for_each_entry(codec, &codec_list, list) { list_for_each_entry(codec, &codec_list, list)
len = snprintf(buf + ret, PAGE_SIZE - ret, "%s\n", seq_printf(m, "%s\n", codec->component.name);
codec->component.name);
if (len >= 0)
ret += len;
if (ret > PAGE_SIZE) {
ret = PAGE_SIZE;
break;
}
}
mutex_unlock(&client_mutex); mutex_unlock(&client_mutex);
if (ret >= 0) return 0;
ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret); }
kfree(buf);
return ret; static int codec_list_seq_open(struct inode *inode, struct file *file)
{
return single_open(file, codec_list_seq_show, NULL);
} }
static const struct file_operations codec_list_fops = { static const struct file_operations codec_list_fops = {
.read = codec_list_read_file, .open = codec_list_seq_open,
.llseek = default_llseek,/* read accesses f_pos */ .read = seq_read,
.llseek = seq_lseek,
.release = single_release,
}; };
static ssize_t dai_list_read_file(struct file *file, char __user *user_buf, static int dai_list_seq_show(struct seq_file *m, void *v)
size_t count, loff_t *ppos)
{ {
char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
ssize_t len, ret = 0;
struct snd_soc_component *component; struct snd_soc_component *component;
struct snd_soc_dai *dai; struct snd_soc_dai *dai;
if (!buf)
return -ENOMEM;
mutex_lock(&client_mutex); mutex_lock(&client_mutex);
list_for_each_entry(component, &component_list, list) { list_for_each_entry(component, &component_list, list)
list_for_each_entry(dai, &component->dai_list, list) { list_for_each_entry(dai, &component->dai_list, list)
len = snprintf(buf + ret, PAGE_SIZE - ret, "%s\n", seq_printf(m, "%s\n", dai->name);
dai->name);
if (len >= 0)
ret += len;
if (ret > PAGE_SIZE) {
ret = PAGE_SIZE;
break;
}
}
}
mutex_unlock(&client_mutex); mutex_unlock(&client_mutex);
ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret); return 0;
}
kfree(buf);
return ret; static int dai_list_seq_open(struct inode *inode, struct file *file)
{
return single_open(file, dai_list_seq_show, NULL);
} }
static const struct file_operations dai_list_fops = { static const struct file_operations dai_list_fops = {
.read = dai_list_read_file, .open = dai_list_seq_open,
.llseek = default_llseek,/* read accesses f_pos */ .read = seq_read,
.llseek = seq_lseek,
.release = single_release,
}; };
static ssize_t platform_list_read_file(struct file *file, static int platform_list_seq_show(struct seq_file *m, void *v)
char __user *user_buf,
size_t count, loff_t *ppos)
{ {
char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
ssize_t len, ret = 0;
struct snd_soc_platform *platform; struct snd_soc_platform *platform;
if (!buf)
return -ENOMEM;
mutex_lock(&client_mutex); mutex_lock(&client_mutex);
list_for_each_entry(platform, &platform_list, list) { list_for_each_entry(platform, &platform_list, list)
len = snprintf(buf + ret, PAGE_SIZE - ret, "%s\n", seq_printf(m, "%s\n", platform->component.name);
platform->component.name);
if (len >= 0)
ret += len;
if (ret > PAGE_SIZE) {
ret = PAGE_SIZE;
break;
}
}
mutex_unlock(&client_mutex); mutex_unlock(&client_mutex);
ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret); return 0;
}
kfree(buf);
return ret; static int platform_list_seq_open(struct inode *inode, struct file *file)
{
return single_open(file, platform_list_seq_show, NULL);
} }
static const struct file_operations platform_list_fops = { static const struct file_operations platform_list_fops = {
.read = platform_list_read_file, .open = platform_list_seq_open,
.llseek = default_llseek,/* read accesses f_pos */ .read = seq_read,
.llseek = seq_lseek,
.release = single_release,
}; };
static void soc_init_card_debugfs(struct snd_soc_card *card) static void soc_init_card_debugfs(struct snd_soc_card *card)
...@@ -491,7 +455,6 @@ static void soc_cleanup_card_debugfs(struct snd_soc_card *card) ...@@ -491,7 +455,6 @@ static void soc_cleanup_card_debugfs(struct snd_soc_card *card)
debugfs_remove_recursive(card->debugfs_card_root); debugfs_remove_recursive(card->debugfs_card_root);
} }
static void snd_soc_debugfs_init(void) static void snd_soc_debugfs_init(void)
{ {
snd_soc_debugfs_root = debugfs_create_dir("asoc", NULL); snd_soc_debugfs_root = debugfs_create_dir("asoc", NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment