Commit 7037bd80 authored by Matt Fleming's avatar Matt Fleming Committed by Guan Xuetao

unicore32: Use set_current_blocked()

As described in e6fa16ab ("signal: sigprocmask() should do
retarget_shared_pending()") the modification of current->blocked is
incorrect as we need to check whether the signal we're about to block
is pending in the shared queue.

Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: default avatarMatt Fleming <matt.fleming@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Acked-by: default avatarGuan Xuetao <gxt@mprc.pku.edu.cn>
parent a50e4213
...@@ -63,10 +63,7 @@ static int restore_sigframe(struct pt_regs *regs, struct sigframe __user *sf) ...@@ -63,10 +63,7 @@ static int restore_sigframe(struct pt_regs *regs, struct sigframe __user *sf)
err = __copy_from_user(&set, &sf->uc.uc_sigmask, sizeof(set)); err = __copy_from_user(&set, &sf->uc.uc_sigmask, sizeof(set));
if (err == 0) { if (err == 0) {
sigdelsetmask(&set, ~_BLOCKABLE); sigdelsetmask(&set, ~_BLOCKABLE);
spin_lock_irq(&current->sighand->siglock); set_current_blocked(&set);
current->blocked = set;
recalc_sigpending();
spin_unlock_irq(&current->sighand->siglock);
} }
err |= __get_user(regs->UCreg_00, &sf->uc.uc_mcontext.regs.UCreg_00); err |= __get_user(regs->UCreg_00, &sf->uc.uc_mcontext.regs.UCreg_00);
...@@ -321,6 +318,7 @@ static int handle_signal(unsigned long sig, struct k_sigaction *ka, ...@@ -321,6 +318,7 @@ static int handle_signal(unsigned long sig, struct k_sigaction *ka,
{ {
struct thread_info *thread = current_thread_info(); struct thread_info *thread = current_thread_info();
struct task_struct *tsk = current; struct task_struct *tsk = current;
sigset_t blocked;
int usig = sig; int usig = sig;
int ret; int ret;
...@@ -372,13 +370,10 @@ static int handle_signal(unsigned long sig, struct k_sigaction *ka, ...@@ -372,13 +370,10 @@ static int handle_signal(unsigned long sig, struct k_sigaction *ka,
/* /*
* Block the signal if we were successful. * Block the signal if we were successful.
*/ */
spin_lock_irq(&tsk->sighand->siglock); sigorsets(&blocked, &tsk->blocked, &ka->sa.sa_mask);
sigorsets(&tsk->blocked, &tsk->blocked,
&ka->sa.sa_mask);
if (!(ka->sa.sa_flags & SA_NODEFER)) if (!(ka->sa.sa_flags & SA_NODEFER))
sigaddset(&tsk->blocked, sig); sigaddset(&blocked, sig);
recalc_sigpending(); set_current_blocked(&blocked);
spin_unlock_irq(&tsk->sighand->siglock);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment