Commit 70876e7c authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

serial: ifx6x60: fix use-after-free on module unload

commit 1e948479 upstream.

Make sure to deregister the SPI driver before releasing the tty driver
to avoid use-after-free in the SPI remove callback where the tty
devices are deregistered.

Fixes: 72d4724e ("serial: ifx6x60: Add modem power off function in the platform reboot process")
Cc: Jun Chen <jun.d.chen@intel.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7faf3f5f
...@@ -1382,9 +1382,9 @@ static struct spi_driver ifx_spi_driver = { ...@@ -1382,9 +1382,9 @@ static struct spi_driver ifx_spi_driver = {
static void __exit ifx_spi_exit(void) static void __exit ifx_spi_exit(void)
{ {
/* unregister */ /* unregister */
spi_unregister_driver(&ifx_spi_driver);
tty_unregister_driver(tty_drv); tty_unregister_driver(tty_drv);
put_tty_driver(tty_drv); put_tty_driver(tty_drv);
spi_unregister_driver(&ifx_spi_driver);
unregister_reboot_notifier(&ifx_modem_reboot_notifier_block); unregister_reboot_notifier(&ifx_modem_reboot_notifier_block);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment