Commit 709aac40 authored by Dmitry Ivanov's avatar Dmitry Ivanov Committed by Ben Hutchings

nl80211: check netlink protocol in socket release notification

commit 8f815cdd upstream.

A non-privileged user can create a netlink socket with the same port_id as
used by an existing open nl80211 netlink socket (e.g. as used by a hostapd
process) with a different protocol number.

Closing this socket will then lead to the notification going to nl80211's
socket release notification handler, and possibly cause an action such as
removing a virtual interface.

Fix this issue by checking that the netlink protocol is NETLINK_GENERIC.
Since generic netlink has no notifier chain of its own, we can't fix the
problem more generically.

Fixes: 026331c4 ("cfg80211/mac80211: allow registering for and sending action frames")
Signed-off-by: default avatarDmitry Ivanov <dima@ubnt.com>
[rewrite commit message]
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 81d3e814
...@@ -7496,7 +7496,7 @@ static int nl80211_netlink_notify(struct notifier_block * nb, ...@@ -7496,7 +7496,7 @@ static int nl80211_netlink_notify(struct notifier_block * nb,
struct cfg80211_registered_device *rdev; struct cfg80211_registered_device *rdev;
struct wireless_dev *wdev; struct wireless_dev *wdev;
if (state != NETLINK_URELEASE) if (state != NETLINK_URELEASE || notify->protocol != NETLINK_GENERIC)
return NOTIFY_DONE; return NOTIFY_DONE;
rcu_read_lock(); rcu_read_lock();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment