Commit 70b5b2b2 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Wim Van Sebroeck

watchdog: shwdt: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230303213716.2123717-32-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent f80e31b3
...@@ -279,13 +279,11 @@ static int sh_wdt_probe(struct platform_device *pdev) ...@@ -279,13 +279,11 @@ static int sh_wdt_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int sh_wdt_remove(struct platform_device *pdev) static void sh_wdt_remove(struct platform_device *pdev)
{ {
watchdog_unregister_device(&sh_wdt_dev); watchdog_unregister_device(&sh_wdt_dev);
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return 0;
} }
static void sh_wdt_shutdown(struct platform_device *pdev) static void sh_wdt_shutdown(struct platform_device *pdev)
...@@ -299,7 +297,7 @@ static struct platform_driver sh_wdt_driver = { ...@@ -299,7 +297,7 @@ static struct platform_driver sh_wdt_driver = {
}, },
.probe = sh_wdt_probe, .probe = sh_wdt_probe,
.remove = sh_wdt_remove, .remove_new = sh_wdt_remove,
.shutdown = sh_wdt_shutdown, .shutdown = sh_wdt_shutdown,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment