Commit 70e12560 authored by Douglas Anderson's avatar Douglas Anderson

drm/panel: panel-simple: Add missing pm_runtime_disable() calls

In commit 3235b0f2 ("drm/panel: panel-simple: Use runtime pm to
avoid excessive unprepare / prepare") we started using pm_runtime, but
my patch neglected to add the proper pm_runtime_disable(). Doh! Add
them now.

Fixes: 3235b0f2 ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare")
Reported-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid
parent 88581137
...@@ -797,12 +797,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) ...@@ -797,12 +797,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
err = drm_panel_of_backlight(&panel->base); err = drm_panel_of_backlight(&panel->base);
if (err) if (err)
goto free_ddc; goto disable_pm_runtime;
drm_panel_add(&panel->base); drm_panel_add(&panel->base);
return 0; return 0;
disable_pm_runtime:
pm_runtime_disable(dev);
free_ddc: free_ddc:
if (panel->ddc) if (panel->ddc)
put_device(&panel->ddc->dev); put_device(&panel->ddc->dev);
...@@ -818,6 +820,7 @@ static int panel_simple_remove(struct device *dev) ...@@ -818,6 +820,7 @@ static int panel_simple_remove(struct device *dev)
drm_panel_disable(&panel->base); drm_panel_disable(&panel->base);
drm_panel_unprepare(&panel->base); drm_panel_unprepare(&panel->base);
pm_runtime_disable(dev);
if (panel->ddc) if (panel->ddc)
put_device(&panel->ddc->dev); put_device(&panel->ddc->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment