Commit 7133eca1 authored by Alexandre Belloni's avatar Alexandre Belloni

rtc: rv8803: switch to rtc_register_device

This removes a possible race condition and allows for further improvement
of the driver.
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 697e5a47
...@@ -577,6 +577,11 @@ static int rv8803_probe(struct i2c_client *client, ...@@ -577,6 +577,11 @@ static int rv8803_probe(struct i2c_client *client,
if (flags & RV8803_FLAG_AF) if (flags & RV8803_FLAG_AF)
dev_warn(&client->dev, "An alarm maybe have been missed.\n"); dev_warn(&client->dev, "An alarm maybe have been missed.\n");
rv8803->rtc = devm_rtc_allocate_device(&client->dev);
if (IS_ERR(rv8803->rtc)) {
return PTR_ERR(rv8803->rtc);
}
if (client->irq > 0) { if (client->irq > 0) {
err = devm_request_threaded_irq(&client->dev, client->irq, err = devm_request_threaded_irq(&client->dev, client->irq,
NULL, rv8803_handle_irq, NULL, rv8803_handle_irq,
...@@ -592,12 +597,10 @@ static int rv8803_probe(struct i2c_client *client, ...@@ -592,12 +597,10 @@ static int rv8803_probe(struct i2c_client *client,
} }
} }
rv8803->rtc = devm_rtc_device_register(&client->dev, client->name, rv8803->rtc->ops = &rv8803_rtc_ops;
&rv8803_rtc_ops, THIS_MODULE); err = rtc_register_device(rv8803->rtc);
if (IS_ERR(rv8803->rtc)) { if (err)
dev_err(&client->dev, "unable to register the class device\n"); return err;
return PTR_ERR(rv8803->rtc);
}
err = rv8803_write_reg(rv8803->client, RV8803_EXT, RV8803_EXT_WADA); err = rv8803_write_reg(rv8803->client, RV8803_EXT, RV8803_EXT_WADA);
if (err) if (err)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment