Commit 721f076b authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski

net: dql: Optimize stall information population

When Dynamic Queue Limit (DQL) is set, it always populate stall
information through dql_queue_stall().  However, this information is
only necessary if a stall threshold is set, stored in struct
dql->stall_thrs.

dql_queue_stall() is cheap, but not free, since it does have memory
barriers and so forth.

Do not call dql_queue_stall() if there is no stall threshold set, and
save some CPU cycles.
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20240411192241.2498631-4-leitao@debian.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent cbe481a1
......@@ -137,7 +137,9 @@ static inline void dql_queued(struct dql *dql, unsigned int count)
dql->num_queued += count;
dql_queue_stall(dql);
/* Only populate stall information if the threshold is set */
if (READ_ONCE(dql->stall_thrs))
dql_queue_stall(dql);
}
/* Returns how many objects can be queued, < 0 indicates over limit. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment