Commit 723478c8 authored by Knut Petersen's avatar Knut Petersen Committed by Ingo Molnar

perf: Enforce 1 as lower limit for perf_event_max_sample_rate

/proc/sys/kernel/perf_event_max_sample_rate will accept
negative values as well as 0.

Negative values are unreasonable, and 0 causes a
divide by zero exception in perf_proc_update_handler.

This patch enforces a lower limit of 1.
Signed-off-by: default avatarKnut Petersen <Knut_Petersen@t-online.de>
Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/5242DB0C.4070005@t-online.deSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 354cc40e
...@@ -193,7 +193,7 @@ int perf_proc_update_handler(struct ctl_table *table, int write, ...@@ -193,7 +193,7 @@ int perf_proc_update_handler(struct ctl_table *table, int write,
void __user *buffer, size_t *lenp, void __user *buffer, size_t *lenp,
loff_t *ppos) loff_t *ppos)
{ {
int ret = proc_dointvec(table, write, buffer, lenp, ppos); int ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
if (ret || !write) if (ret || !write)
return ret; return ret;
......
...@@ -1049,6 +1049,7 @@ static struct ctl_table kern_table[] = { ...@@ -1049,6 +1049,7 @@ static struct ctl_table kern_table[] = {
.maxlen = sizeof(sysctl_perf_event_sample_rate), .maxlen = sizeof(sysctl_perf_event_sample_rate),
.mode = 0644, .mode = 0644,
.proc_handler = perf_proc_update_handler, .proc_handler = perf_proc_update_handler,
.extra1 = &one,
}, },
{ {
.procname = "perf_cpu_time_max_percent", .procname = "perf_cpu_time_max_percent",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment