Commit 726816a1 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by David S. Miller

net: dsa: make cross-chip notifiers more efficient for host events

To determine whether a given port should react to the port targeted by
the notifier, dsa_port_host_vlan_match() and dsa_port_host_address_match()
look at the positioning of the switch port currently executing the
notifier relative to the switch port for which the notifier was emitted.

To maintain stylistic compatibility with the other match functions from
switch.c, the host address and host VLAN match functions take the
notifier information about targeted port, switch and tree indices as
argument. However, these functions only use that information to retrieve
the struct dsa_port *targeted_dp, which is an invariant for the outer
loop that calls them. So it makes more sense to calculate the targeted
dp only once, and pass it to them as argument.

But furthermore, the targeted dp is actually known at the time the call
to dsa_port_notify() is made. It is just that we decide to only save the
indices of the port, switch and tree in the notifier structure, just to
retrace our steps and find the dp again using dsa_switch_find() and
dsa_to_port().

But both the above functions are relatively expensive, since they need
to iterate through lists. It appears more straightforward to make all
notifiers just pass the targeted dp inside their info structure, and
have the code that needs the indices to look at info->dp->index instead
of info->port, or info->dp->ds->index instead of info->sw_index, or
info->dp->ds->dst->index instead of info->tree_index.

For the sake of consistency, all cross-chip notifiers are converted to
pass the "dp" directly.
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8e9e678e
...@@ -54,18 +54,15 @@ struct dsa_notifier_ageing_time_info { ...@@ -54,18 +54,15 @@ struct dsa_notifier_ageing_time_info {
/* DSA_NOTIFIER_BRIDGE_* */ /* DSA_NOTIFIER_BRIDGE_* */
struct dsa_notifier_bridge_info { struct dsa_notifier_bridge_info {
const struct dsa_port *dp;
struct dsa_bridge bridge; struct dsa_bridge bridge;
int tree_index;
int sw_index;
int port;
bool tx_fwd_offload; bool tx_fwd_offload;
struct netlink_ext_ack *extack; struct netlink_ext_ack *extack;
}; };
/* DSA_NOTIFIER_FDB_* */ /* DSA_NOTIFIER_FDB_* */
struct dsa_notifier_fdb_info { struct dsa_notifier_fdb_info {
int sw_index; const struct dsa_port *dp;
int port;
const unsigned char *addr; const unsigned char *addr;
u16 vid; u16 vid;
struct dsa_db db; struct dsa_db db;
...@@ -81,34 +78,29 @@ struct dsa_notifier_lag_fdb_info { ...@@ -81,34 +78,29 @@ struct dsa_notifier_lag_fdb_info {
/* DSA_NOTIFIER_MDB_* */ /* DSA_NOTIFIER_MDB_* */
struct dsa_notifier_mdb_info { struct dsa_notifier_mdb_info {
const struct dsa_port *dp;
const struct switchdev_obj_port_mdb *mdb; const struct switchdev_obj_port_mdb *mdb;
int sw_index;
int port;
struct dsa_db db; struct dsa_db db;
}; };
/* DSA_NOTIFIER_LAG_* */ /* DSA_NOTIFIER_LAG_* */
struct dsa_notifier_lag_info { struct dsa_notifier_lag_info {
const struct dsa_port *dp;
struct dsa_lag lag; struct dsa_lag lag;
int sw_index;
int port;
struct netdev_lag_upper_info *info; struct netdev_lag_upper_info *info;
}; };
/* DSA_NOTIFIER_VLAN_* */ /* DSA_NOTIFIER_VLAN_* */
struct dsa_notifier_vlan_info { struct dsa_notifier_vlan_info {
const struct dsa_port *dp;
const struct switchdev_obj_port_vlan *vlan; const struct switchdev_obj_port_vlan *vlan;
int sw_index;
int port;
struct netlink_ext_ack *extack; struct netlink_ext_ack *extack;
}; };
/* DSA_NOTIFIER_MTU */ /* DSA_NOTIFIER_MTU */
struct dsa_notifier_mtu_info { struct dsa_notifier_mtu_info {
const struct dsa_port *dp;
bool targeted_match; bool targeted_match;
int sw_index;
int port;
int mtu; int mtu;
}; };
...@@ -119,9 +111,7 @@ struct dsa_notifier_tag_proto_info { ...@@ -119,9 +111,7 @@ struct dsa_notifier_tag_proto_info {
/* DSA_NOTIFIER_TAG_8021Q_VLAN_* */ /* DSA_NOTIFIER_TAG_8021Q_VLAN_* */
struct dsa_notifier_tag_8021q_vlan_info { struct dsa_notifier_tag_8021q_vlan_info {
int tree_index; const struct dsa_port *dp;
int sw_index;
int port;
u16 vid; u16 vid;
}; };
......
...@@ -459,9 +459,7 @@ int dsa_port_bridge_join(struct dsa_port *dp, struct net_device *br, ...@@ -459,9 +459,7 @@ int dsa_port_bridge_join(struct dsa_port *dp, struct net_device *br,
struct netlink_ext_ack *extack) struct netlink_ext_ack *extack)
{ {
struct dsa_notifier_bridge_info info = { struct dsa_notifier_bridge_info info = {
.tree_index = dp->ds->dst->index, .dp = dp,
.sw_index = dp->ds->index,
.port = dp->index,
.extack = extack, .extack = extack,
}; };
struct net_device *dev = dp->slave; struct net_device *dev = dp->slave;
...@@ -530,9 +528,7 @@ void dsa_port_pre_bridge_leave(struct dsa_port *dp, struct net_device *br) ...@@ -530,9 +528,7 @@ void dsa_port_pre_bridge_leave(struct dsa_port *dp, struct net_device *br)
void dsa_port_bridge_leave(struct dsa_port *dp, struct net_device *br) void dsa_port_bridge_leave(struct dsa_port *dp, struct net_device *br)
{ {
struct dsa_notifier_bridge_info info = { struct dsa_notifier_bridge_info info = {
.tree_index = dp->ds->dst->index, .dp = dp,
.sw_index = dp->ds->index,
.port = dp->index,
}; };
int err; int err;
...@@ -562,8 +558,7 @@ int dsa_port_lag_change(struct dsa_port *dp, ...@@ -562,8 +558,7 @@ int dsa_port_lag_change(struct dsa_port *dp,
struct netdev_lag_lower_state_info *linfo) struct netdev_lag_lower_state_info *linfo)
{ {
struct dsa_notifier_lag_info info = { struct dsa_notifier_lag_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
}; };
bool tx_enabled; bool tx_enabled;
...@@ -632,8 +627,7 @@ int dsa_port_lag_join(struct dsa_port *dp, struct net_device *lag_dev, ...@@ -632,8 +627,7 @@ int dsa_port_lag_join(struct dsa_port *dp, struct net_device *lag_dev,
struct netlink_ext_ack *extack) struct netlink_ext_ack *extack)
{ {
struct dsa_notifier_lag_info info = { struct dsa_notifier_lag_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.info = uinfo, .info = uinfo,
}; };
struct net_device *bridge_dev; struct net_device *bridge_dev;
...@@ -678,8 +672,7 @@ void dsa_port_lag_leave(struct dsa_port *dp, struct net_device *lag_dev) ...@@ -678,8 +672,7 @@ void dsa_port_lag_leave(struct dsa_port *dp, struct net_device *lag_dev)
{ {
struct net_device *br = dsa_port_bridge_dev_get(dp); struct net_device *br = dsa_port_bridge_dev_get(dp);
struct dsa_notifier_lag_info info = { struct dsa_notifier_lag_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
}; };
int err; int err;
...@@ -941,9 +934,8 @@ int dsa_port_mtu_change(struct dsa_port *dp, int new_mtu, ...@@ -941,9 +934,8 @@ int dsa_port_mtu_change(struct dsa_port *dp, int new_mtu,
bool targeted_match) bool targeted_match)
{ {
struct dsa_notifier_mtu_info info = { struct dsa_notifier_mtu_info info = {
.sw_index = dp->ds->index, .dp = dp,
.targeted_match = targeted_match, .targeted_match = targeted_match,
.port = dp->index,
.mtu = new_mtu, .mtu = new_mtu,
}; };
...@@ -954,8 +946,7 @@ int dsa_port_fdb_add(struct dsa_port *dp, const unsigned char *addr, ...@@ -954,8 +946,7 @@ int dsa_port_fdb_add(struct dsa_port *dp, const unsigned char *addr,
u16 vid) u16 vid)
{ {
struct dsa_notifier_fdb_info info = { struct dsa_notifier_fdb_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.addr = addr, .addr = addr,
.vid = vid, .vid = vid,
.db = { .db = {
...@@ -978,8 +969,7 @@ int dsa_port_fdb_del(struct dsa_port *dp, const unsigned char *addr, ...@@ -978,8 +969,7 @@ int dsa_port_fdb_del(struct dsa_port *dp, const unsigned char *addr,
u16 vid) u16 vid)
{ {
struct dsa_notifier_fdb_info info = { struct dsa_notifier_fdb_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.addr = addr, .addr = addr,
.vid = vid, .vid = vid,
.db = { .db = {
...@@ -999,8 +989,7 @@ static int dsa_port_host_fdb_add(struct dsa_port *dp, ...@@ -999,8 +989,7 @@ static int dsa_port_host_fdb_add(struct dsa_port *dp,
struct dsa_db db) struct dsa_db db)
{ {
struct dsa_notifier_fdb_info info = { struct dsa_notifier_fdb_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.addr = addr, .addr = addr,
.vid = vid, .vid = vid,
.db = db, .db = db,
...@@ -1051,8 +1040,7 @@ static int dsa_port_host_fdb_del(struct dsa_port *dp, ...@@ -1051,8 +1040,7 @@ static int dsa_port_host_fdb_del(struct dsa_port *dp,
struct dsa_db db) struct dsa_db db)
{ {
struct dsa_notifier_fdb_info info = { struct dsa_notifier_fdb_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.addr = addr, .addr = addr,
.vid = vid, .vid = vid,
.db = db, .db = db,
...@@ -1147,8 +1135,7 @@ int dsa_port_mdb_add(const struct dsa_port *dp, ...@@ -1147,8 +1135,7 @@ int dsa_port_mdb_add(const struct dsa_port *dp,
const struct switchdev_obj_port_mdb *mdb) const struct switchdev_obj_port_mdb *mdb)
{ {
struct dsa_notifier_mdb_info info = { struct dsa_notifier_mdb_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.mdb = mdb, .mdb = mdb,
.db = { .db = {
.type = DSA_DB_BRIDGE, .type = DSA_DB_BRIDGE,
...@@ -1166,8 +1153,7 @@ int dsa_port_mdb_del(const struct dsa_port *dp, ...@@ -1166,8 +1153,7 @@ int dsa_port_mdb_del(const struct dsa_port *dp,
const struct switchdev_obj_port_mdb *mdb) const struct switchdev_obj_port_mdb *mdb)
{ {
struct dsa_notifier_mdb_info info = { struct dsa_notifier_mdb_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.mdb = mdb, .mdb = mdb,
.db = { .db = {
.type = DSA_DB_BRIDGE, .type = DSA_DB_BRIDGE,
...@@ -1186,8 +1172,7 @@ static int dsa_port_host_mdb_add(const struct dsa_port *dp, ...@@ -1186,8 +1172,7 @@ static int dsa_port_host_mdb_add(const struct dsa_port *dp,
struct dsa_db db) struct dsa_db db)
{ {
struct dsa_notifier_mdb_info info = { struct dsa_notifier_mdb_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.mdb = mdb, .mdb = mdb,
.db = db, .db = db,
}; };
...@@ -1231,8 +1216,7 @@ static int dsa_port_host_mdb_del(const struct dsa_port *dp, ...@@ -1231,8 +1216,7 @@ static int dsa_port_host_mdb_del(const struct dsa_port *dp,
struct dsa_db db) struct dsa_db db)
{ {
struct dsa_notifier_mdb_info info = { struct dsa_notifier_mdb_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.mdb = mdb, .mdb = mdb,
.db = db, .db = db,
}; };
...@@ -1276,8 +1260,7 @@ int dsa_port_vlan_add(struct dsa_port *dp, ...@@ -1276,8 +1260,7 @@ int dsa_port_vlan_add(struct dsa_port *dp,
struct netlink_ext_ack *extack) struct netlink_ext_ack *extack)
{ {
struct dsa_notifier_vlan_info info = { struct dsa_notifier_vlan_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.vlan = vlan, .vlan = vlan,
.extack = extack, .extack = extack,
}; };
...@@ -1289,8 +1272,7 @@ int dsa_port_vlan_del(struct dsa_port *dp, ...@@ -1289,8 +1272,7 @@ int dsa_port_vlan_del(struct dsa_port *dp,
const struct switchdev_obj_port_vlan *vlan) const struct switchdev_obj_port_vlan *vlan)
{ {
struct dsa_notifier_vlan_info info = { struct dsa_notifier_vlan_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.vlan = vlan, .vlan = vlan,
}; };
...@@ -1302,8 +1284,7 @@ int dsa_port_host_vlan_add(struct dsa_port *dp, ...@@ -1302,8 +1284,7 @@ int dsa_port_host_vlan_add(struct dsa_port *dp,
struct netlink_ext_ack *extack) struct netlink_ext_ack *extack)
{ {
struct dsa_notifier_vlan_info info = { struct dsa_notifier_vlan_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.vlan = vlan, .vlan = vlan,
.extack = extack, .extack = extack,
}; };
...@@ -1323,8 +1304,7 @@ int dsa_port_host_vlan_del(struct dsa_port *dp, ...@@ -1323,8 +1304,7 @@ int dsa_port_host_vlan_del(struct dsa_port *dp,
const struct switchdev_obj_port_vlan *vlan) const struct switchdev_obj_port_vlan *vlan)
{ {
struct dsa_notifier_vlan_info info = { struct dsa_notifier_vlan_info info = {
.sw_index = dp->ds->index, .dp = dp,
.port = dp->index,
.vlan = vlan, .vlan = vlan,
}; };
struct dsa_port *cpu_dp = dp->cpu_dp; struct dsa_port *cpu_dp = dp->cpu_dp;
...@@ -1743,9 +1723,7 @@ void dsa_port_hsr_leave(struct dsa_port *dp, struct net_device *hsr) ...@@ -1743,9 +1723,7 @@ void dsa_port_hsr_leave(struct dsa_port *dp, struct net_device *hsr)
int dsa_port_tag_8021q_vlan_add(struct dsa_port *dp, u16 vid, bool broadcast) int dsa_port_tag_8021q_vlan_add(struct dsa_port *dp, u16 vid, bool broadcast)
{ {
struct dsa_notifier_tag_8021q_vlan_info info = { struct dsa_notifier_tag_8021q_vlan_info info = {
.tree_index = dp->ds->dst->index, .dp = dp,
.sw_index = dp->ds->index,
.port = dp->index,
.vid = vid, .vid = vid,
}; };
...@@ -1758,9 +1736,7 @@ int dsa_port_tag_8021q_vlan_add(struct dsa_port *dp, u16 vid, bool broadcast) ...@@ -1758,9 +1736,7 @@ int dsa_port_tag_8021q_vlan_add(struct dsa_port *dp, u16 vid, bool broadcast)
void dsa_port_tag_8021q_vlan_del(struct dsa_port *dp, u16 vid, bool broadcast) void dsa_port_tag_8021q_vlan_del(struct dsa_port *dp, u16 vid, bool broadcast)
{ {
struct dsa_notifier_tag_8021q_vlan_info info = { struct dsa_notifier_tag_8021q_vlan_info info = {
.tree_index = dp->ds->dst->index, .dp = dp,
.sw_index = dp->ds->index,
.port = dp->index,
.vid = vid, .vid = vid,
}; };
int err; int err;
......
This diff is collapsed.
...@@ -196,15 +196,7 @@ static bool ...@@ -196,15 +196,7 @@ static bool
dsa_port_tag_8021q_vlan_match(struct dsa_port *dp, dsa_port_tag_8021q_vlan_match(struct dsa_port *dp,
struct dsa_notifier_tag_8021q_vlan_info *info) struct dsa_notifier_tag_8021q_vlan_info *info)
{ {
struct dsa_switch *ds = dp->ds; return dsa_port_is_dsa(dp) || dsa_port_is_cpu(dp) || dp == info->dp;
if (dsa_port_is_dsa(dp) || dsa_port_is_cpu(dp))
return true;
if (ds->dst->index == info->tree_index && ds->index == info->sw_index)
return dp->index == info->port;
return false;
} }
int dsa_switch_tag_8021q_vlan_add(struct dsa_switch *ds, int dsa_switch_tag_8021q_vlan_add(struct dsa_switch *ds,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment