Commit 72a763d8 authored by Mathias Krause's avatar Mathias Krause Committed by Herbert Xu

crypto: algif - suppress sending source address information in recvmsg

The current code does not set the msg_namelen member to 0 and therefore
makes net/socket.c leak the local sockaddr_storage variable to userland
-- 128 bytes of kernel stack memory. Fix that.

Cc: <stable@vger.kernel.org> # 2.6.38
Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent d47cbd5b
...@@ -161,6 +161,8 @@ static int hash_recvmsg(struct kiocb *unused, struct socket *sock, ...@@ -161,6 +161,8 @@ static int hash_recvmsg(struct kiocb *unused, struct socket *sock,
else if (len < ds) else if (len < ds)
msg->msg_flags |= MSG_TRUNC; msg->msg_flags |= MSG_TRUNC;
msg->msg_namelen = 0;
lock_sock(sk); lock_sock(sk);
if (ctx->more) { if (ctx->more) {
ctx->more = 0; ctx->more = 0;
......
...@@ -432,6 +432,7 @@ static int skcipher_recvmsg(struct kiocb *unused, struct socket *sock, ...@@ -432,6 +432,7 @@ static int skcipher_recvmsg(struct kiocb *unused, struct socket *sock,
long copied = 0; long copied = 0;
lock_sock(sk); lock_sock(sk);
msg->msg_namelen = 0;
for (iov = msg->msg_iov, iovlen = msg->msg_iovlen; iovlen > 0; for (iov = msg->msg_iov, iovlen = msg->msg_iovlen; iovlen > 0;
iovlen--, iov++) { iovlen--, iov++) {
unsigned long seglen = iov->iov_len; unsigned long seglen = iov->iov_len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment