Commit 72ae5822 authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini

KVM: x86/mmu: Use "unsigned int", not "u32", for SPTEs' @access info

Use an "unsigned int" for @access parameters instead of a "u32", mostly
to be consistent throughout KVM, but also because "u32" is misleading.
@access can actually squeeze into a u8, i.e. doesn't need 32 bits, but is
as an "unsigned int" because sp->role.access is an unsigned int.

No functional change intended.

Link: https://lore.kernel.org/all/YqyZxEfxXLsHGoZ%2F@google.com
Cc: David Matlack <dmatlack@google.com>
Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Message-Id: <20220624171808.2845941-3-seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent db209369
...@@ -717,7 +717,8 @@ static u32 kvm_mmu_page_get_access(struct kvm_mmu_page *sp, int index) ...@@ -717,7 +717,8 @@ static u32 kvm_mmu_page_get_access(struct kvm_mmu_page *sp, int index)
return sp->role.access; return sp->role.access;
} }
static void kvm_mmu_page_set_translation(struct kvm_mmu_page *sp, int index, gfn_t gfn, u32 access) static void kvm_mmu_page_set_translation(struct kvm_mmu_page *sp, int index,
gfn_t gfn, unsigned int access)
{ {
if (sp_has_gptes(sp)) { if (sp_has_gptes(sp)) {
sp->shadowed_translation[index] = (gfn << PAGE_SHIFT) | access; sp->shadowed_translation[index] = (gfn << PAGE_SHIFT) | access;
...@@ -735,7 +736,8 @@ static void kvm_mmu_page_set_translation(struct kvm_mmu_page *sp, int index, gfn ...@@ -735,7 +736,8 @@ static void kvm_mmu_page_set_translation(struct kvm_mmu_page *sp, int index, gfn
sp->gfn, kvm_mmu_page_get_gfn(sp, index), gfn); sp->gfn, kvm_mmu_page_get_gfn(sp, index), gfn);
} }
static void kvm_mmu_page_set_access(struct kvm_mmu_page *sp, int index, u32 access) static void kvm_mmu_page_set_access(struct kvm_mmu_page *sp, int index,
unsigned int access)
{ {
gfn_t gfn = kvm_mmu_page_get_gfn(sp, index); gfn_t gfn = kvm_mmu_page_get_gfn(sp, index);
...@@ -1580,7 +1582,7 @@ static bool kvm_test_age_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head, ...@@ -1580,7 +1582,7 @@ static bool kvm_test_age_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head,
static void __rmap_add(struct kvm *kvm, static void __rmap_add(struct kvm *kvm,
struct kvm_mmu_memory_cache *cache, struct kvm_mmu_memory_cache *cache,
const struct kvm_memory_slot *slot, const struct kvm_memory_slot *slot,
u64 *spte, gfn_t gfn, u32 access) u64 *spte, gfn_t gfn, unsigned int access)
{ {
struct kvm_mmu_page *sp; struct kvm_mmu_page *sp;
struct kvm_rmap_head *rmap_head; struct kvm_rmap_head *rmap_head;
...@@ -1601,7 +1603,7 @@ static void __rmap_add(struct kvm *kvm, ...@@ -1601,7 +1603,7 @@ static void __rmap_add(struct kvm *kvm,
} }
static void rmap_add(struct kvm_vcpu *vcpu, const struct kvm_memory_slot *slot, static void rmap_add(struct kvm_vcpu *vcpu, const struct kvm_memory_slot *slot,
u64 *spte, gfn_t gfn, u32 access) u64 *spte, gfn_t gfn, unsigned int access)
{ {
struct kvm_mmu_memory_cache *cache = &vcpu->arch.mmu_pte_list_desc_cache; struct kvm_mmu_memory_cache *cache = &vcpu->arch.mmu_pte_list_desc_cache;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment