Commit 731b0085 authored by Ursula Braun's avatar Ursula Braun Committed by David S. Miller

net/smc: take RCU read lock for routing cache lookup

smc_netinfo_by_tcpsk() looks up the routing cache. Such a lookup requires
protection by an RCU read lock.
Signed-off-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 846e344e
...@@ -282,6 +282,7 @@ int smc_netinfo_by_tcpsk(struct socket *clcsock, ...@@ -282,6 +282,7 @@ int smc_netinfo_by_tcpsk(struct socket *clcsock,
__be32 *subnet, u8 *prefix_len) __be32 *subnet, u8 *prefix_len)
{ {
struct dst_entry *dst = sk_dst_get(clcsock->sk); struct dst_entry *dst = sk_dst_get(clcsock->sk);
struct in_device *in_dev;
struct sockaddr_in addr; struct sockaddr_in addr;
int rc = -ENOENT; int rc = -ENOENT;
int len; int len;
...@@ -298,14 +299,17 @@ int smc_netinfo_by_tcpsk(struct socket *clcsock, ...@@ -298,14 +299,17 @@ int smc_netinfo_by_tcpsk(struct socket *clcsock,
/* get address to which the internal TCP socket is bound */ /* get address to which the internal TCP socket is bound */
kernel_getsockname(clcsock, (struct sockaddr *)&addr, &len); kernel_getsockname(clcsock, (struct sockaddr *)&addr, &len);
/* analyze IPv4 specific data of net_device belonging to TCP socket */ /* analyze IPv4 specific data of net_device belonging to TCP socket */
for_ifa(dst->dev->ip_ptr) { rcu_read_lock();
if (ifa->ifa_address != addr.sin_addr.s_addr) in_dev = __in_dev_get_rcu(dst->dev);
for_ifa(in_dev) {
if (!inet_ifa_match(addr.sin_addr.s_addr, ifa))
continue; continue;
*prefix_len = inet_mask_len(ifa->ifa_mask); *prefix_len = inet_mask_len(ifa->ifa_mask);
*subnet = ifa->ifa_address & ifa->ifa_mask; *subnet = ifa->ifa_address & ifa->ifa_mask;
rc = 0; rc = 0;
break; break;
} endfor_ifa(dst->dev->ip_ptr); } endfor_ifa(in_dev);
rcu_read_unlock();
out_rel: out_rel:
dst_release(dst); dst_release(dst);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment