Commit 745b5364 authored by Laurentiu Tudor's avatar Laurentiu Tudor Committed by Greg Kroah-Hartman

staging: fsl-mc: use generic memory barriers

No need to use arch-specific memory barriers; switch to using generic
ones. The rmb()s were useless so drop them.
Signed-off-by: default avatarLaurentiu Tudor <laurentiu.tudor@nxp.com>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 87840fb5
...@@ -127,7 +127,8 @@ static inline void mc_write_command(struct mc_command __iomem *portal, ...@@ -127,7 +127,8 @@ static inline void mc_write_command(struct mc_command __iomem *portal,
/* copy command parameters into the portal */ /* copy command parameters into the portal */
for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++) for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++)
__raw_writeq(cmd->params[i], &portal->params[i]); __raw_writeq(cmd->params[i], &portal->params[i]);
__iowmb(); /* ensure command params are committed before submitting it */
wmb();
/* submit the command by writing the header */ /* submit the command by writing the header */
__raw_writeq(cmd->header, &portal->header); __raw_writeq(cmd->header, &portal->header);
...@@ -150,9 +151,7 @@ static inline enum mc_cmd_status mc_read_response(struct mc_command __iomem * ...@@ -150,9 +151,7 @@ static inline enum mc_cmd_status mc_read_response(struct mc_command __iomem *
enum mc_cmd_status status; enum mc_cmd_status status;
/* Copy command response header from MC portal: */ /* Copy command response header from MC portal: */
__iormb();
resp->header = __raw_readq(&portal->header); resp->header = __raw_readq(&portal->header);
__iormb();
status = mc_cmd_hdr_read_status(resp); status = mc_cmd_hdr_read_status(resp);
if (status != MC_CMD_STATUS_OK) if (status != MC_CMD_STATUS_OK)
return status; return status;
...@@ -160,7 +159,6 @@ static inline enum mc_cmd_status mc_read_response(struct mc_command __iomem * ...@@ -160,7 +159,6 @@ static inline enum mc_cmd_status mc_read_response(struct mc_command __iomem *
/* Copy command response data from MC portal: */ /* Copy command response data from MC portal: */
for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++) for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++)
resp->params[i] = __raw_readq(&portal->params[i]); resp->params[i] = __raw_readq(&portal->params[i]);
__iormb();
return status; return status;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment