Commit 7483e1a4 authored by Miao Xie's avatar Miao Xie Committed by Josef Bacik

Btrfs: remove unnecessary memory barrier in btrfs_sync_log()

Mutex unlock implies certain memory barriers to make sure all the memory
operation completes before the unlock, and the next mutex lock implies memory
barriers to make sure the all the memory happens after the lock. So it is
a full memory barrier(smp_mb), we needn't add memory barriers. Remove them.
Signed-off-by: default avatarMiao Xie <miaox@cn.fujitsu.com>
Signed-off-by: default avatarJosef Bacik <jbacik@fb.com>
parent e87ac136
...@@ -2496,7 +2496,6 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans, ...@@ -2496,7 +2496,6 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans,
root->log_transid++; root->log_transid++;
log->log_transid = root->log_transid; log->log_transid = root->log_transid;
root->log_start_pid = 0; root->log_start_pid = 0;
smp_mb();
/* /*
* IO has been started, blocks of the log tree have WRITTEN flag set * IO has been started, blocks of the log tree have WRITTEN flag set
* in their headers. new modifications of the log will be written to * in their headers. new modifications of the log will be written to
...@@ -2589,8 +2588,6 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans, ...@@ -2589,8 +2588,6 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans,
btrfs_header_level(log_root_tree->node)); btrfs_header_level(log_root_tree->node));
log_root_tree->log_transid++; log_root_tree->log_transid++;
smp_mb();
mutex_unlock(&log_root_tree->log_mutex); mutex_unlock(&log_root_tree->log_mutex);
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment