Commit 74a622be authored by Thomas Gleixner's avatar Thomas Gleixner Committed by John Stultz

ia64: vsyscall: Use seqcount instead of seqlock

The update of the vdso data happens under xtime_lock, so adding a
nested lock is pointless. Just use a seqcount to sync the readers.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
parent 2ab51657
...@@ -269,8 +269,8 @@ void foo(void) ...@@ -269,8 +269,8 @@ void foo(void)
BLANK(); BLANK();
/* used by fsys_gettimeofday in arch/ia64/kernel/fsys.S */ /* used by fsys_gettimeofday in arch/ia64/kernel/fsys.S */
DEFINE(IA64_GTOD_LOCK_OFFSET, DEFINE(IA64_GTOD_SEQ_OFFSET,
offsetof (struct fsyscall_gtod_data_t, lock)); offsetof (struct fsyscall_gtod_data_t, seq);
DEFINE(IA64_GTOD_WALL_TIME_OFFSET, DEFINE(IA64_GTOD_WALL_TIME_OFFSET,
offsetof (struct fsyscall_gtod_data_t, wall_time)); offsetof (struct fsyscall_gtod_data_t, wall_time));
DEFINE(IA64_GTOD_MONO_TIME_OFFSET, DEFINE(IA64_GTOD_MONO_TIME_OFFSET,
......
...@@ -174,7 +174,7 @@ ENTRY(fsys_set_tid_address) ...@@ -174,7 +174,7 @@ ENTRY(fsys_set_tid_address)
FSYS_RETURN FSYS_RETURN
END(fsys_set_tid_address) END(fsys_set_tid_address)
#if IA64_GTOD_LOCK_OFFSET !=0 #if IA64_GTOD_SEQ_OFFSET !=0
#error fsys_gettimeofday incompatible with changes to struct fsyscall_gtod_data_t #error fsys_gettimeofday incompatible with changes to struct fsyscall_gtod_data_t
#endif #endif
#if IA64_ITC_JITTER_OFFSET !=0 #if IA64_ITC_JITTER_OFFSET !=0
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
*/ */
struct fsyscall_gtod_data_t { struct fsyscall_gtod_data_t {
seqlock_t lock; seqcount_t seq;
struct timespec wall_time; struct timespec wall_time;
struct timespec monotonic_time; struct timespec monotonic_time;
cycle_t clk_mask; cycle_t clk_mask;
......
...@@ -35,9 +35,7 @@ ...@@ -35,9 +35,7 @@
static cycle_t itc_get_cycles(struct clocksource *cs); static cycle_t itc_get_cycles(struct clocksource *cs);
struct fsyscall_gtod_data_t fsyscall_gtod_data = { struct fsyscall_gtod_data_t fsyscall_gtod_data;
.lock = __SEQLOCK_UNLOCKED(fsyscall_gtod_data.lock),
};
struct itc_jitter_data_t itc_jitter_data; struct itc_jitter_data_t itc_jitter_data;
...@@ -460,9 +458,7 @@ void update_vsyscall_tz(void) ...@@ -460,9 +458,7 @@ void update_vsyscall_tz(void)
void update_vsyscall(struct timespec *wall, struct timespec *wtm, void update_vsyscall(struct timespec *wall, struct timespec *wtm,
struct clocksource *c, u32 mult) struct clocksource *c, u32 mult)
{ {
unsigned long flags; write_seqcount_begin(&fsyscall_gtod_data.seq);
write_seqlock_irqsave(&fsyscall_gtod_data.lock, flags);
/* copy fsyscall clock data */ /* copy fsyscall clock data */
fsyscall_gtod_data.clk_mask = c->mask; fsyscall_gtod_data.clk_mask = c->mask;
...@@ -485,6 +481,6 @@ void update_vsyscall(struct timespec *wall, struct timespec *wtm, ...@@ -485,6 +481,6 @@ void update_vsyscall(struct timespec *wall, struct timespec *wtm,
fsyscall_gtod_data.monotonic_time.tv_sec++; fsyscall_gtod_data.monotonic_time.tv_sec++;
} }
write_sequnlock_irqrestore(&fsyscall_gtod_data.lock, flags); write_seqcount_end(&fsyscall_gtod_data.seq);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment