Commit 74ffe79a authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Russell King

ARM: 8840/1: use a raw_spinlock_t in unwind

Mostly unwind is done with irqs enabled however SLUB may call it with
irqs disabled while creating a new SLUB cache.

I had system freeze while loading a module which called
kmem_cache_create() on init. That means SLUB's __slab_alloc() disabled
interrupts and then

->new_slab_objects()
 ->new_slab()
  ->setup_object()
   ->setup_object_debug()
    ->init_tracking()
     ->set_track()
      ->save_stack_trace()
       ->save_stack_trace_tsk()
        ->walk_stackframe()
         ->unwind_frame()
          ->unwind_find_idx()
           =>spin_lock_irqsave(&unwind_lock);
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
parent 143c2a89
...@@ -93,7 +93,7 @@ extern const struct unwind_idx __start_unwind_idx[]; ...@@ -93,7 +93,7 @@ extern const struct unwind_idx __start_unwind_idx[];
static const struct unwind_idx *__origin_unwind_idx; static const struct unwind_idx *__origin_unwind_idx;
extern const struct unwind_idx __stop_unwind_idx[]; extern const struct unwind_idx __stop_unwind_idx[];
static DEFINE_SPINLOCK(unwind_lock); static DEFINE_RAW_SPINLOCK(unwind_lock);
static LIST_HEAD(unwind_tables); static LIST_HEAD(unwind_tables);
/* Convert a prel31 symbol to an absolute address */ /* Convert a prel31 symbol to an absolute address */
...@@ -201,7 +201,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) ...@@ -201,7 +201,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr)
/* module unwind tables */ /* module unwind tables */
struct unwind_table *table; struct unwind_table *table;
spin_lock_irqsave(&unwind_lock, flags); raw_spin_lock_irqsave(&unwind_lock, flags);
list_for_each_entry(table, &unwind_tables, list) { list_for_each_entry(table, &unwind_tables, list) {
if (addr >= table->begin_addr && if (addr >= table->begin_addr &&
addr < table->end_addr) { addr < table->end_addr) {
...@@ -213,7 +213,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) ...@@ -213,7 +213,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr)
break; break;
} }
} }
spin_unlock_irqrestore(&unwind_lock, flags); raw_spin_unlock_irqrestore(&unwind_lock, flags);
} }
pr_debug("%s: idx = %p\n", __func__, idx); pr_debug("%s: idx = %p\n", __func__, idx);
...@@ -529,9 +529,9 @@ struct unwind_table *unwind_table_add(unsigned long start, unsigned long size, ...@@ -529,9 +529,9 @@ struct unwind_table *unwind_table_add(unsigned long start, unsigned long size,
tab->begin_addr = text_addr; tab->begin_addr = text_addr;
tab->end_addr = text_addr + text_size; tab->end_addr = text_addr + text_size;
spin_lock_irqsave(&unwind_lock, flags); raw_spin_lock_irqsave(&unwind_lock, flags);
list_add_tail(&tab->list, &unwind_tables); list_add_tail(&tab->list, &unwind_tables);
spin_unlock_irqrestore(&unwind_lock, flags); raw_spin_unlock_irqrestore(&unwind_lock, flags);
return tab; return tab;
} }
...@@ -543,9 +543,9 @@ void unwind_table_del(struct unwind_table *tab) ...@@ -543,9 +543,9 @@ void unwind_table_del(struct unwind_table *tab)
if (!tab) if (!tab)
return; return;
spin_lock_irqsave(&unwind_lock, flags); raw_spin_lock_irqsave(&unwind_lock, flags);
list_del(&tab->list); list_del(&tab->list);
spin_unlock_irqrestore(&unwind_lock, flags); raw_spin_unlock_irqrestore(&unwind_lock, flags);
kfree(tab); kfree(tab);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment