Commit 757b9bd0 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman

staging: bcm2835: mark all symbols as 'static'

I got a link error in allyesconfig:

drivers/staging/media/platform/bcm2835/bcm2835-camera.o: In function `vidioc_enum_framesizes':
bcm2835-camera.c:(.text.vidioc_enum_framesizes+0x0): multiple definition of `vidioc_enum_framesizes'
drivers/media/platform/vivid/vivid-vid-cap.o:vivid-vid-cap.c:(.text.vidioc_enum_framesizes+0x0): first defined here

While both drivers are equally at fault for this problem, the bcm2835 one was
just added and is easier to fix, as it is only one file, and none of its symbols
need to be globally visible. This marks the three global symbols as static.

Fixes: 7b3ad5ab ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b07525b8
...@@ -50,7 +50,7 @@ MODULE_AUTHOR("Vincent Sanders"); ...@@ -50,7 +50,7 @@ MODULE_AUTHOR("Vincent Sanders");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
MODULE_VERSION(BM2835_MMAL_VERSION); MODULE_VERSION(BM2835_MMAL_VERSION);
int bcm2835_v4l2_debug; static int bcm2835_v4l2_debug;
module_param_named(debug, bcm2835_v4l2_debug, int, 0644); module_param_named(debug, bcm2835_v4l2_debug, int, 0644);
MODULE_PARM_DESC(bcm2835_v4l2_debug, "Debug level 0-2"); MODULE_PARM_DESC(bcm2835_v4l2_debug, "Debug level 0-2");
...@@ -1312,7 +1312,7 @@ static int vidioc_s_fmt_vid_cap(struct file *file, void *priv, ...@@ -1312,7 +1312,7 @@ static int vidioc_s_fmt_vid_cap(struct file *file, void *priv,
return ret; return ret;
} }
int vidioc_enum_framesizes(struct file *file, void *fh, static int vidioc_enum_framesizes(struct file *file, void *fh,
struct v4l2_frmsizeenum *fsize) struct v4l2_frmsizeenum *fsize)
{ {
struct bm2835_mmal_dev *dev = video_drvdata(file); struct bm2835_mmal_dev *dev = video_drvdata(file);
...@@ -1842,7 +1842,7 @@ static int __init bm2835_mmal_init_device(struct bm2835_mmal_dev *dev, ...@@ -1842,7 +1842,7 @@ static int __init bm2835_mmal_init_device(struct bm2835_mmal_dev *dev,
return 0; return 0;
} }
void bcm2835_cleanup_instance(struct bm2835_mmal_dev *dev) static void bcm2835_cleanup_instance(struct bm2835_mmal_dev *dev)
{ {
if (!dev) if (!dev)
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment