Commit 75874d5c authored by Chuck Ebbert's avatar Chuck Ebbert Committed by Linus Torvalds

[PATCH] i386: fix dump_stack()

i386 has a small bug in the stack dump code where it prints an extra log
level code.  Remove that and fix the alignment of normal stack dump
printout.  Also remove some unnecessary printk() calls.
Signed-off-by: default avatarChuck Ebbert <76306.1226@compuserve.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 4ef0652a
...@@ -217,19 +217,17 @@ static void show_stack_log_lvl(struct task_struct *task, unsigned long *esp, ...@@ -217,19 +217,17 @@ static void show_stack_log_lvl(struct task_struct *task, unsigned long *esp,
for(i = 0; i < kstack_depth_to_print; i++) { for(i = 0; i < kstack_depth_to_print; i++) {
if (kstack_end(stack)) if (kstack_end(stack))
break; break;
if (i && ((i % 8) == 0)) { if (i && ((i % 8) == 0))
printk("\n"); printk("\n%s ", log_lvl);
printk("%s ", log_lvl);
}
printk("%08lx ", *stack++); printk("%08lx ", *stack++);
} }
printk("\n"); printk("\n%sCall Trace:\n", log_lvl);
printk("%sCall Trace:\n", log_lvl);
show_trace_log_lvl(task, esp, log_lvl); show_trace_log_lvl(task, esp, log_lvl);
} }
void show_stack(struct task_struct *task, unsigned long *esp) void show_stack(struct task_struct *task, unsigned long *esp)
{ {
printk(" ");
show_stack_log_lvl(task, esp, ""); show_stack_log_lvl(task, esp, "");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment