Commit 75d68369 authored by Himanshu Jha's avatar Himanshu Jha Committed by Herbert Xu

crypto: Use zeroing memory allocator instead of allocator/memset

Use dma_zalloc_coherent for allocating zeroed
memory and remove unnecessary memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.
Signed-off-by: default avatarHimanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent b7dac373
...@@ -282,14 +282,12 @@ static u32 crypto4xx_put_pd_to_pdr(struct crypto4xx_device *dev, u32 idx) ...@@ -282,14 +282,12 @@ static u32 crypto4xx_put_pd_to_pdr(struct crypto4xx_device *dev, u32 idx)
*/ */
static u32 crypto4xx_build_gdr(struct crypto4xx_device *dev) static u32 crypto4xx_build_gdr(struct crypto4xx_device *dev)
{ {
dev->gdr = dma_alloc_coherent(dev->core_dev->device, dev->gdr = dma_zalloc_coherent(dev->core_dev->device,
sizeof(struct ce_gd) * PPC4XX_NUM_GD, sizeof(struct ce_gd) * PPC4XX_NUM_GD,
&dev->gdr_pa, GFP_ATOMIC); &dev->gdr_pa, GFP_ATOMIC);
if (!dev->gdr) if (!dev->gdr)
return -ENOMEM; return -ENOMEM;
memset(dev->gdr, 0, sizeof(struct ce_gd) * PPC4XX_NUM_GD);
return 0; return 0;
} }
......
...@@ -260,12 +260,11 @@ static int setup_crypt_desc(void) ...@@ -260,12 +260,11 @@ static int setup_crypt_desc(void)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
BUILD_BUG_ON(sizeof(struct crypt_ctl) != 64); BUILD_BUG_ON(sizeof(struct crypt_ctl) != 64);
crypt_virt = dma_alloc_coherent(dev, crypt_virt = dma_zalloc_coherent(dev,
NPE_QLEN * sizeof(struct crypt_ctl), NPE_QLEN * sizeof(struct crypt_ctl),
&crypt_phys, GFP_ATOMIC); &crypt_phys, GFP_ATOMIC);
if (!crypt_virt) if (!crypt_virt)
return -ENOMEM; return -ENOMEM;
memset(crypt_virt, 0, NPE_QLEN * sizeof(struct crypt_ctl));
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment