Commit 760a9a30 authored by Alan Cox's avatar Alan Cox Committed by Marcelo Tosatti

kvm: Fix nonsense handling of compat ioctl

KVM_SET_SIGNAL_MASK passed a NULL argument leaves the on stack signal
sets uninitialized. It then passes them through to
kvm_vcpu_ioctl_set_sigmask.

We should be passing a NULL in this case not translated garbage.
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
parent 9acb1725
...@@ -1976,9 +1976,10 @@ static long kvm_vcpu_compat_ioctl(struct file *filp, ...@@ -1976,9 +1976,10 @@ static long kvm_vcpu_compat_ioctl(struct file *filp,
if (copy_from_user(&csigset, sigmask_arg->sigset, if (copy_from_user(&csigset, sigmask_arg->sigset,
sizeof csigset)) sizeof csigset))
goto out; goto out;
} sigset_from_compat(&sigset, &csigset);
sigset_from_compat(&sigset, &csigset); r = kvm_vcpu_ioctl_set_sigmask(vcpu, &sigset);
r = kvm_vcpu_ioctl_set_sigmask(vcpu, &sigset); } else
r = kvm_vcpu_ioctl_set_sigmask(vcpu, NULL);
break; break;
} }
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment