Commit 76291469 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen

scsi: aacraid: rcode is unsigned and should be signed int

aac_fib_send can return -ve error returns and hence rcode should be
signed. Currently the rcode >= 0 check is always true and -ve errors are
not being checked.

Thanks to Dan Carpenter for spotting my original broken fix to this
issue.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarRaghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a76037ff
...@@ -1798,7 +1798,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan) ...@@ -1798,7 +1798,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan)
struct sgmap64 *sg64; struct sgmap64 *sg64;
dma_addr_t addr; dma_addr_t addr;
u32 vbus, vid; u32 vbus, vid;
u32 rcode = 0; int rcode = 0;
/* Thor SA Firmware -> CISS_REPORT_PHYSICAL_LUNS */ /* Thor SA Firmware -> CISS_REPORT_PHYSICAL_LUNS */
fibsize = sizeof(struct aac_srb) - sizeof(struct sgentry) fibsize = sizeof(struct aac_srb) - sizeof(struct sgentry)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment